From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF32M-0003zm-5M for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF32L-0001uO-Ac for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:26:30 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:41678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF32L-0001ts-4k for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:26:29 -0400 Date: Tue, 14 Jul 2015 18:26:26 +0200 From: Aurelien Jarno Message-ID: <20150714162626.GA7569@aurel32.net> References: <1436868495-4359-1-git-send-email-leon.alrae@imgtec.com> <1436868495-4359-2-git-send-email-leon.alrae@imgtec.com> <20150714154536.GA7039@aurel32.net> <55A5373A.20806@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A5373A.20806@imgtec.com> Subject: Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: qemu-devel@nongnu.org On 2015-07-14 17:22, Leon Alrae wrote: > On 14/07/2015 16:45, Aurelien Jarno wrote: > > By the way, is this debug code really useful? I think by looking at the > > TCG code (-d in_asm,op), it's easy to determine if an instruction is > > correctly disassembled or not. > > > > For me this debug code doesn't seem to be useful at all and it only clutters > translate.c :) In this patch I just wanted to make Coverity happy so I > followed the existing code but generally would vote for removal all of MIPS_DEBUG. Ok, I'll work on a patch for 2.5. That said I think we should still merge the patch for 2.4. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net