diff for duplicates of <20150715030508.GA20352@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 5cb9212..7c1995e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote: > +#define big_addr 0x800000 > +#define mmio_addr 0x00800000 > +#define seqw17 smtc_seqw(0x17, 0x30) -> +#define big_pixel_depth(p, d) {if (p = 24) {p = 32; d = 32; } } +> +#define big_pixel_depth(p, d) {if (p == 24) {p = 32; d = 32; } } > +#define big_swap(p) ((p & 0xff00ff00 >> 8) | (p & 0x00ff00ff << 8)) > +#else > +#define pal_rgb(r, g, b, val) val @@ -36,7 +36,7 @@ On Tue, Jul 07, 2015 at 01:44:36PM +0530, Sudip Mukherjee wrote: Odd, empty macros are not good, because: > -#ifdef __BIG_ENDIAN -> if (sfb->fb->var.bits_per_pixel = 32) +> if (sfb->fb->var.bits_per_pixel == 32) > - smtc_seqw(0x17, 0x30); > -#endif > + seqw17; diff --git a/a/content_digest b/N1/content_digest index 5a8dd07..37454a5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01436256877-10754-5-git-send-email-sudipm.mukherjee@gmail.com\0" "From\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>\0" "Subject\0Re: [PATCH 4/5] staging: sm7xxfb: define new macros\0" - "Date\0Wed, 15 Jul 2015 03:05:08 +0000\0" + "Date\0Tue, 14 Jul 2015 20:05:08 -0700\0" "To\0Sudip Mukherjee <sudipm.mukherjee@gmail.com>\0" "Cc\0devel@driverdev.osuosl.org" linux-fbdev@vger.kernel.org @@ -37,7 +37,7 @@ "> +#define big_addr\t\t0x800000\n" "> +#define mmio_addr\t\t0x00800000\n" "> +#define seqw17\t\t\tsmtc_seqw(0x17, 0x30)\n" - "> +#define big_pixel_depth(p, d)\t{if (p = 24) {p = 32; d = 32; } }\n" + "> +#define big_pixel_depth(p, d)\t{if (p == 24) {p = 32; d = 32; } }\n" "> +#define big_swap(p)\t\t((p & 0xff00ff00 >> 8) | (p & 0x00ff00ff << 8))\n" "> +#else\n" "> +#define pal_rgb(r, g, b, val)\tval\n" @@ -48,11 +48,11 @@ "Odd, empty macros are not good, because:\n" "\n" "> -#ifdef __BIG_ENDIAN\n" - "> \t\tif (sfb->fb->var.bits_per_pixel = 32)\n" + "> \t\tif (sfb->fb->var.bits_per_pixel == 32)\n" "> -\t\t\tsmtc_seqw(0x17, 0x30);\n" "> -#endif\n" "> +\t\t\tseqw17;\n" "\n" That just looks wrong :( -b2c86248ffd8f0405fc66de7288eaec7abd45fc4998edb68b1a98efefe31c39c +a1adb33486e4edd43bf63af4c093cbdd18a5a70fec04452faea12614aff76766
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.