From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib_stats
Date: Wed, 15 Jul 2015 10:27:20 +0530 [thread overview]
Message-ID: <20150715045720.GB17865@sudip-PC> (raw)
In-Reply-To: <1436904266-25297-6-git-send-email-mateusz.kulikowski@gmail.com>
On Tue, Jul 14, 2015 at 10:04:08PM +0200, Mateusz Kulikowski wrote:
> None of them are used in the driver.
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib.h | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 8ba92ed..dc0653a 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -691,27 +691,8 @@ struct rtllib_frag_entry {
> };
>
> struct rtllib_stats {
> - unsigned int tx_unicast_frames;
> - unsigned int tx_multicast_frames;
> - unsigned int tx_fragments;
> - unsigned int tx_unicast_octets;
> - unsigned int tx_multicast_octets;
> - unsigned int tx_deferred_transmissions;
> - unsigned int tx_single_retry_frames;
> - unsigned int tx_multiple_retry_frames;
> - unsigned int tx_retry_limit_exceeded;
> unsigned int tx_discards;
> - unsigned int rx_unicast_frames;
> - unsigned int rx_multicast_frames;
> - unsigned int rx_fragments;
> - unsigned int rx_unicast_octets;
> - unsigned int rx_multicast_octets;
> - unsigned int rx_fcs_errors;
> - unsigned int rx_discards_no_buffer;
> - unsigned int tx_discards_wrong_sa;
> unsigned int rx_discards_undecryptable;
Dan had commented before that tx_discards and rx_discards_undecryptable
are also not used. Their only uses are:
ieee->ieee_stats.rx_discards_undecryptable++ and
ieee->ieee_stats.tx_discards++
regards
sudip
next prev parent reply other threads:[~2015-07-15 4:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 20:04 [PATCH v2 00/23] staging: rtl8192e: Various cleanups Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 01/23] staging: rtl8192e: Remove ToLegalChannel() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 02/23] staging: rtl8192e: Remove unused defines Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 03/23] staging: rtl8192e: Remove undefs Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 04/23] staging: rtl8192e: Remove unused enums Mateusz Kulikowski
2015-07-15 6:34 ` Jakub Sitnicki
2015-07-15 7:05 ` Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 05/23] staging: rtl8192e: Remove unused fields from rtllib_stats Mateusz Kulikowski
2015-07-15 4:57 ` Sudip Mukherjee [this message]
2015-07-15 4:58 ` Sudip Mukherjee
2015-07-14 20:04 ` [PATCH v2 06/23] staging: rtl8192e: Remove rtllib_stats structure Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 07/23] staging: rtl8192e: Remove unused ether_header structure Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 08/23] staging: rtl8192e: Remove unused rtllib_device::freq_band Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 09/23] staging: rtl8192e: Remove DOT11D_GetMaxTxPwrInDbm() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 10/23] staging: rtl8192e: Remove read|write_nic_io_(d)word|byte() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 11/23] staging: rtl8192e: Remove DMESG macro Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 12/23] staging: rtl8192e: Remove rtl819x_process_cck_rxpathsel() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 13/23] staging: rtl8192e: probe: Remove bdma64 check Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 14/23] staging: rtl8192e: Remove rtl8192_rx_cmd() Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 15/23] staging: rtl8192e: rtl_dm: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 16/23] staging: rtl8192e: rtllib_HTProc: " Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 17/23] staging: rtl8192e: Make phy_RF8256_Config_ParaFile() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 18/23] staging: rtl8192e: rtl_core: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 19/23] staging: rtl8192e: r8192e_phy: " Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 20/23] staging: rtl8192e: Make rtl8192_QueryIsShort() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 21/23] staging: rtl8192e: rtllib_tx: Make functions static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 22/23] staging: rtl8192e: Make rtllib_rx_mgt() static Mateusz Kulikowski
2015-07-14 20:04 ` [PATCH v2 23/23] staging: rtl8192e: rtllib_softmac: Make functions static Mateusz Kulikowski
2015-07-16 9:58 ` [PATCH v2 00/23] staging: rtl8192e: Various cleanups Dan Carpenter
2015-07-17 19:52 ` Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715045720.GB17865@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.