From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH v1 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors
Date: Wed, 15 Jul 2015 01:29:53 -0700 [thread overview]
Message-ID: <20150715082953.GC6684@infradead.org> (raw)
In-Reply-To: <1436946939-19415-4-git-send-email-sagig@mellanox.com>
On Wed, Jul 15, 2015 at 10:55:38AM +0300, Sagi Grimberg wrote:
> In case a LU spans 64bit sectors, fixed size sense data information
> field is only 32 bits which means the sector information will be truncated.
>
> Thus, if the LU spans 64bit sectors, use descriptor format sense data to
> correctly report sector information.
>
> Reported-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2015-07-15 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 7:55 [PATCH v1 0/4] Descriptor format sense data Sagi Grimberg
2015-07-15 7:55 ` [PATCH v1 1/4] scsi: Fix wrong additional sense length in descriptor format Sagi Grimberg
2015-07-15 8:27 ` Christoph Hellwig
2015-07-15 7:55 ` [PATCH v1 2/4] scsi: Protect against buffer possible overflow in scsi_set_sense_information Sagi Grimberg
2015-07-15 8:29 ` Christoph Hellwig
2015-07-15 7:55 ` [PATCH v1 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors Sagi Grimberg
2015-07-15 8:06 ` Hannes Reinecke
2015-07-15 8:29 ` Christoph Hellwig [this message]
2015-07-15 14:07 ` Bart Van Assche
2015-07-16 0:34 ` Martin K. Petersen
2015-07-15 7:55 ` [PATCH v1 4/4] libiscsi: Use scsi helper to set information descriptor Sagi Grimberg
2015-07-15 8:07 ` Hannes Reinecke
2015-07-15 8:30 ` Christoph Hellwig
2015-07-16 0:33 ` Martin K. Petersen
2015-07-24 5:59 ` [PATCH v1 0/4] Descriptor format sense data Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715082953.GC6684@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.