All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	namhyung@kernel.org, Jiri Olsa <jolsa@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH perf/core ] [BUGFIX] perf build-test: Add linux/export.h and lib/rbtree.c to MANIFEST
Date: Wed, 15 Jul 2015 08:22:17 -0300	[thread overview]
Message-ID: <20150715112217.GB3868@kernel.org> (raw)
In-Reply-To: <20150715060718.10311.42010.stgit@localhost.localdomain>

Em Wed, Jul 15, 2015 at 03:07:18PM +0900, Masami Hiramatsu escreveu:
> Since linux/export.h and lib/rbtree.c are not listed in MANIFEST,
> `make build-test` always fails as below (Note, to get these messages,
> I've removed /dev/null redirect in tests/perf-targz-src-pkg);

See:

https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=4756e1966c4e1c00a2c6e379cea0322429d1a29b
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=perf/urgent&id=0aefc3590afcc9ecbe173fc01fccbda0869d2f0a

Summary: The fix below is wrong, the right one was pushed to Ingo and
should make its way to Linus soon,

- Arnaldo
 
>   ----
>     CC       util/hweight.o
>   ../../lib/hweight.c:1:26: fatal error: linux/export.h:
>   No such file or directory
>    #include <linux/export.h>
>                           ^
>   compilation terminated.
>   make[3]: *** [util/hweight.o] Error 1
>   ----
> 
>   ----
>     GEN      common-cmds.h
>   make[1]: *** No rule to make target `../../lib/rbtree.c',
>   needed by `python/perf.so'.  Stop.
>   make[1]: *** Waiting for unfinished jobs....
>   ----
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
>  tools/perf/MANIFEST |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> index 09dc0aa..adce9de 100644
> --- a/tools/perf/MANIFEST
> +++ b/tools/perf/MANIFEST
> @@ -58,7 +58,9 @@ include/linux/list.h
>  include/linux/hash.h
>  include/linux/stringify.h
>  lib/hweight.c
> +lib/rbtree.c
>  include/linux/swab.h
> +include/linux/export.h
>  arch/*/include/asm/unistd*.h
>  arch/*/include/uapi/asm/unistd*.h
>  arch/*/include/uapi/asm/perf_regs.h
> 

  reply	other threads:[~2015-07-15 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  6:07 [PATCH perf/core ] [BUGFIX] perf build-test: Add linux/export.h and lib/rbtree.c to MANIFEST Masami Hiramatsu
2015-07-15 11:22 ` Arnaldo Carvalho de Melo [this message]
2015-07-15 13:51   ` Masami Hiramatsu
2015-07-15 14:11     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150715112217.GB3868@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.