From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH libdrm 4/4] Consistently check the fd value Date: Wed, 15 Jul 2015 13:47:50 +0200 Message-ID: <20150715114749.GD15045@ulmo.nvidia.com> References: <1436883005-6163-1-git-send-email-emil.l.velikov@gmail.com> <1436883005-6163-4-git-send-email-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1297956525==" Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C2476E281 for ; Wed, 15 Jul 2015 04:47:57 -0700 (PDT) Received: by pactm7 with SMTP id tm7so23183041pac.2 for ; Wed, 15 Jul 2015 04:47:57 -0700 (PDT) In-Reply-To: <1436883005-6163-4-git-send-email-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1297956525== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="48TaNjbzBVislYPb" Content-Disposition: inline --48TaNjbzBVislYPb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 03:10:05PM +0100, Emil Velikov wrote: > Follow the approach used through the rest of the project. >=20 > Cc: Thierry Reding > Suggested-by: Thierry Reding > Signed-off-by: Emil Velikov > --- > intel/test_decode.c | 2 +- > tests/name_from_fd.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding > diff --git a/intel/test_decode.c b/intel/test_decode.c > index bef86bb..b4eddcd 100644 > --- a/intel/test_decode.c > +++ b/intel/test_decode.c > @@ -56,7 +56,7 @@ read_file(const char *filename, void **ptr, size_t *siz= e) > struct stat st; > =20 > fd =3D open(filename, O_RDONLY); > - if (fd =3D=3D -1) > + if (fd < 0) > errx(1, "couldn't open `%s'", filename); > =20 > ret =3D fstat(fd, &st); > diff --git a/tests/name_from_fd.c b/tests/name_from_fd.c > index 24af6e6..5264681 100644 > --- a/tests/name_from_fd.c > +++ b/tests/name_from_fd.c > @@ -45,7 +45,7 @@ int main(int argc, char **argv) > char *v; > =20 > fd =3D open("/dev/dri/card0", O_RDWR); > - if (fd =3D=3D -1) > + if (fd < 0) > return 0; > =20 > v =3D drmGetDeviceNameFromFd(fd); > --=20 > 2.4.5 >=20 --48TaNjbzBVislYPb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVpkhkAAoJEN0jrNd/PrOhGP4QAIDXSUIikaMrO7HXE0L4k9Wi usXwTA9jEfg2a8MGV0NwmlUy6HsMTkaBZvxAX69PxEXo2VB7QM8NWlpRx2ZHPYlO jU3eJwwS5Rr05be39/MdWX0jdTnJmP+eG+HmORpBVCtRND2egl4IDYCoyLLQxvvP rhhqBZhHeb1aPKe+IDTrIcaL2mSeP5IpqaO71djiYPDZM7xoEYYAWf3rUmOLws7m OBqKgCgT3OkOLMNb+GRa+nrMo1cGV0OymI64IesXDpytKIDhQxUbENyG09MUKhV3 +YrUkXiJtTAyfU0A0r6+HPX4so2sbGeVXtxwe1DYCBUt83ap0kSXtlgJ70XPNAcq SybeAgxG4Ue4kVcVGvkCut7t3yeVr4Nsql4wV6VxDVRoLr2WNgCAHdVjxanFkcpD W2Zxxx5Ehw8EToNQR/Z0LYMk8Drb0ZixVF/NPle3pkK32tHho5lEuqEAqwoSwmyG oNGDnnegrM8vQgySmDpFRl5HTi2xFxT28RvojfRwsxLalda5EF/IGxHTwt1usXVk LA+rnKN2CjvKTDnOhXPhlB0ltem8hOVxbmI03OeIF+SrJEA3S1GY08sFNjgJKkz1 V1c2O0SIQLJYQm20tH6QBVOLGKWt+vmbkfDhz1O9Mo3KAr7aBFkFxwfVMXXq6tTc jBPXlGFlT3QwdX03gnb5 =BSSn -----END PGP SIGNATURE----- --48TaNjbzBVislYPb-- --===============1297956525== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1297956525==--