From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: Igor Mammedov <imammedo@redhat.com>,
Peter Krempa <pkrempa@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on
Date: Wed, 15 Jul 2015 19:08:02 +0300 [thread overview]
Message-ID: <20150715190709-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CABYiri_x0N_mbjSLzSoXuduzwDVTQTCD9kmCq=pT=AQevcNc+A@mail.gmail.com>
On Wed, Jul 15, 2015 at 06:26:03PM +0300, Andrey Korolyov wrote:
> On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov <imammedo@redhat.com> wrote:
> > On Thu, 9 Jul 2015 20:04:35 +0300
> > Andrey Korolyov <andrey@xdel.ru> wrote:
> >
> >> On Wed, Jul 8, 2015 at 6:46 PM, Igor Mammedov <imammedo@redhat.com> wrote:
> >> > On Wed, 8 Jul 2015 13:01:05 +0300
> >> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >> >
> >> > [...]
> >> >> - this fixes qemu on current kernels, so it's a bugfix
> >> >>
> >> >> - this changes the semantics of memory hot unplug slightly
> >> >> so I think it's important to merge in 2.4 before we
> >> >> release qemu with memory hot unplug, this way we
> >> >> won't have to maintain old semantics forever
> >> > concerning semantic change, I've just chatted with Peter
> >> > who implemented libvirt side of the memory hotplug stack.
> >> > And it's not a problem for libvirt since it always does
> >> > unplug dimm -> remove backend sequence.
> >> >
> >> >
> >>
> >>
> >> Just for the record - top of the series somehow fixed mysterious guest
> >> memory corruption issue described in
> >> https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg03117.html
> >> which existed right from a moment of a memory hotplug introduction, I
> >> checked series for its disappearance only with vhost for now. Thanks
> >> Igor!
> > just to be sure which patch exactly fixed issue for you?
> >
>
> Had not bisected this yet, 2.3 is fairly distant from mine production
> yet... will post a result today or tomorrow. Until then, I`ll be
> absolutely out of clues of what was behind mentioned corruption.
Igor merely asked which of his 8 patches fixed it.
--
MST
next prev parent reply other threads:[~2015-07-15 16:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:46 [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 1/8] memory: get rid of memory_region_destructor_ram_from_ptr() Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 2/8] memory: introduce MemoryRegion container with reserved HVA range Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 3/8] pc: reserve hotpluggable memory range with memory_region_init_hva_range() Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 4/8] pc: fix QEMU crashing when more than ~50 memory hotplugged Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 5/8] exec: make sure that RAMBlock descriptor won't be leaked Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 6/8] exec: add qemu_ram_unmap_hva() API for unmapping memory from HVA area Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 7/8] memory: extend memory_region_add_subregion() to support error reporting Igor Mammedov
2015-07-08 11:03 ` Michael S. Tsirkin
2015-07-08 11:09 ` Peter Maydell
2015-07-08 14:58 ` Igor Mammedov
2015-07-08 17:30 ` Michael S. Tsirkin
2015-07-08 18:41 ` Igor Mammedov
2015-07-09 6:58 ` Michael S. Tsirkin
2015-07-08 17:42 ` Paolo Bonzini
2015-07-08 18:58 ` Igor Mammedov
2015-07-08 9:46 ` [Qemu-devel] [RFC v3 8/8] memory: add support for deleting HVA mapped MemoryRegion Igor Mammedov
2015-07-08 9:58 ` Michael S. Tsirkin
2015-07-08 14:43 ` Igor Mammedov
2015-07-08 14:50 ` Michael S. Tsirkin
2015-07-08 10:01 ` [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on Michael S. Tsirkin
2015-07-08 11:41 ` Igor Mammedov
2015-07-08 11:45 ` Michael S. Tsirkin
2015-07-08 15:46 ` Igor Mammedov
2015-07-09 17:04 ` Andrey Korolyov
2015-07-15 15:18 ` Igor Mammedov
2015-07-15 15:26 ` Andrey Korolyov
2015-07-15 16:08 ` Michael S. Tsirkin [this message]
2015-07-15 16:46 ` Andrey Korolyov
2015-07-16 20:35 ` Andrey Korolyov
2015-07-17 20:45 ` Andrey Korolyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715190709-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=andrey@xdel.ru \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.