From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Davydov Subject: Re: [PATCH -mm v8 4/7] proc: add kpagecgroup file Date: Thu, 16 Jul 2015 12:28:41 +0300 Message-ID: <20150716092841.GA2001@esperanza> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Transfer-Encoding: 7bit To: Andres Lagar-Cavilla Cc: Andrew Morton , Minchan Kim , Raghavendra K T , Johannes Weiner , Michal Hocko , Greg Thelen , Michel Lespinasse , David Rientjes , Pavel Emelyanov , Cyrill Gorcunov , Jonathan Corbet , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Jul 15, 2015 at 12:03:18PM -0700, Andres Lagar-Cavilla wrote: > For both /proc/kpage* interfaces you add (and more critically for the > rmap-causing one, kpageidle): > > It's a good idea to do cond_sched(). Whether after each pfn, each Nth > pfn, each put_user, I leave to you, but a reasonable cadence is > needed, because user-space can call this on the entire physical > address space, and that's a lot of work to do without re-scheduling. I really don't think it's necessary. These files can only be read/written by the root, who has plenty ways to kill the system anyway. The program that is allowed to read/write these files must be conscious and do it in batches of reasonable size. AFAICS the same reasoning already lays behind /proc/kpagecount and /proc/kpageflag, which also do not thrust the "right" batch size on their readers. Thanks, Vladimir From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 78FE12802DE for ; Thu, 16 Jul 2015 05:28:57 -0400 (EDT) Received: by pdbqm3 with SMTP id qm3so41400685pdb.0 for ; Thu, 16 Jul 2015 02:28:57 -0700 (PDT) Received: from mx2.parallels.com (mx2.parallels.com. [199.115.105.18]) by mx.google.com with ESMTPS id xh6si12078158pbc.57.2015.07.16.02.28.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 02:28:56 -0700 (PDT) Date: Thu, 16 Jul 2015 12:28:41 +0300 From: Vladimir Davydov Subject: Re: [PATCH -mm v8 4/7] proc: add kpagecgroup file Message-ID: <20150716092841.GA2001@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Andres Lagar-Cavilla Cc: Andrew Morton , Minchan Kim , Raghavendra K T , Johannes Weiner , Michal Hocko , Greg Thelen , Michel Lespinasse , David Rientjes , Pavel Emelyanov , Cyrill Gorcunov , Jonathan Corbet , linux-api@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jul 15, 2015 at 12:03:18PM -0700, Andres Lagar-Cavilla wrote: > For both /proc/kpage* interfaces you add (and more critically for the > rmap-causing one, kpageidle): > > It's a good idea to do cond_sched(). Whether after each pfn, each Nth > pfn, each put_user, I leave to you, but a reasonable cadence is > needed, because user-space can call this on the entire physical > address space, and that's a lot of work to do without re-scheduling. I really don't think it's necessary. These files can only be read/written by the root, who has plenty ways to kill the system anyway. The program that is allowed to read/write these files must be conscious and do it in batches of reasonable size. AFAICS the same reasoning already lays behind /proc/kpagecount and /proc/kpageflag, which also do not thrust the "right" batch size on their readers. Thanks, Vladimir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbbGPJ26 (ORCPT ); Thu, 16 Jul 2015 05:28:58 -0400 Received: from mx2.parallels.com ([199.115.105.18]:48242 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbGPJ2y (ORCPT ); Thu, 16 Jul 2015 05:28:54 -0400 Date: Thu, 16 Jul 2015 12:28:41 +0300 From: Vladimir Davydov To: Andres Lagar-Cavilla CC: Andrew Morton , Minchan Kim , Raghavendra K T , Johannes Weiner , Michal Hocko , Greg Thelen , Michel Lespinasse , David Rientjes , Pavel Emelyanov , Cyrill Gorcunov , Jonathan Corbet , , , , , Subject: Re: [PATCH -mm v8 4/7] proc: add kpagecgroup file Message-ID: <20150716092841.GA2001@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.30.4.177] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 15, 2015 at 12:03:18PM -0700, Andres Lagar-Cavilla wrote: > For both /proc/kpage* interfaces you add (and more critically for the > rmap-causing one, kpageidle): > > It's a good idea to do cond_sched(). Whether after each pfn, each Nth > pfn, each put_user, I leave to you, but a reasonable cadence is > needed, because user-space can call this on the entire physical > address space, and that's a lot of work to do without re-scheduling. I really don't think it's necessary. These files can only be read/written by the root, who has plenty ways to kill the system anyway. The program that is allowed to read/write these files must be conscious and do it in batches of reasonable size. AFAICS the same reasoning already lays behind /proc/kpagecount and /proc/kpageflag, which also do not thrust the "right" batch size on their readers. Thanks, Vladimir