From: Thomas Graf <tgraf@suug.ch>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords
Date: Thu, 16 Jul 2015 12:41:46 +0200 [thread overview]
Message-ID: <20150716104146.GA22603@pox.localdomain> (raw)
In-Reply-To: <1437040973-31531-1-git-send-email-dvlasenk@redhat.com>
On 07/16/15 at 12:02pm, Denys Vlasenko wrote:
> +/* jhash - hash an arbitrary key
> + * @k: sequence of bytes as key
> + * @length: the length of the key
> + * @initval: the previous hash, or an arbitray value
> + *
> + * The generic version, hashes an arbitrary sequence of bytes.
> + * No alignment or length assumptions are made about the input key.
> + *
> + * Returns the hash value of the key. The result depends on endianness.
> + */
> +u32 jhash(const void *key, u32 length, u32 initval)
Shouldn't these live in lib/jhash.c or something? Otherwise
everyone needs to depend on CONFIG_RHASHTABLE
next prev parent reply other threads:[~2015-07-16 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 10:02 [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords Denys Vlasenko
2015-07-16 10:41 ` Thomas Graf [this message]
2015-07-16 12:15 ` Denys Vlasenko
2015-07-16 12:28 ` Daniel Borkmann
2015-07-16 14:04 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716104146.GA22603@pox.localdomain \
--to=tgraf@suug.ch \
--cc=alexander.h.duyck@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.