From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: sti: fix sub-components bind Date: Thu, 16 Jul 2015 12:59:14 +0200 Message-ID: <20150716105912.GA4200@ulmo> References: <1436966506-21386-1-git-send-email-benjamin.gaignard@linaro.org> <20150715133447.GI15045@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0843393365==" Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13ED36EC56 for ; Thu, 16 Jul 2015 03:59:21 -0700 (PDT) Received: by wibud3 with SMTP id ud3so12649195wib.0 for ; Thu, 16 Jul 2015 03:59:19 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard Cc: Russell King , "dri-devel@lists.freedesktop.org" , XinWei Kong , "Liguozhu (Kenneth)" List-Id: dri-devel@lists.freedesktop.org --===============0843393365== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 15, 2015 at 03:56:41PM +0200, Benjamin Gaignard wrote: > It doesn't change any bindings fields, only remove one level of childs on= DT. > Old DTBs may not work but it will impact only very few peoples and no > products so it isn't a problem. I know, that can be said of most platforms, but the decision was made to consider DT a stable ABI, so you can't just go and break it. You'll have to take this up with the ARM SoC maintainers. In the past they've been known to request people to go through extra pain to avoid breaking DT backwards-compatibility. > The patch fix driver and DT files so I don't think it could create issues. That doesn't count. Somebody could still be using an old DTB and not be able (or unwilling) to reflash it. Irrespective, you're probably going to want to split up your patch into driver and DTS changes. The DTS and binding changes will need to be reviewed by the device tree maintainers, and I'd expect that the STi maintainers will want to weigh in as well. Thierry > 2015-07-15 15:34 GMT+02:00 Thierry Reding : > > On Wed, Jul 15, 2015 at 03:21:46PM +0200, Benjamin Gaignard wrote: > >> Fix misunderstanding in how use component framework. > >> drm_platform_init() is now call only when all the > >> sub-components are register themselves instead of the > >> previous two stages mechanism. > >> > >> Update devicetree and bindings documentation according > >> to this new behavior. > >> > >> Signed-off-by: Benjamin Gaignard > >> --- > >> .../devicetree/bindings/gpu/st,stih4xx.txt | 7 +- > >> arch/arm/boot/dts/stih407.dtsi | 82 +++++++++++--= --------- > >> arch/arm/boot/dts/stih410.dtsi | 82 +++++++++++--= --------- > >> drivers/gpu/drm/sti/sti_drm_drv.c | 45 ++---------- > >> drivers/gpu/drm/sti/sti_hdmi.c | 25 ++++--- > >> drivers/gpu/drm/sti/sti_tvout.c | 46 ++---------- > >> 6 files changed, 105 insertions(+), 182 deletions(-) > > > > Isn't this going to break DT ABI? How are you going to ensure backwards- > > compatibility with old DTBs? > > > > Thierry >=20 >=20 >=20 > --=20 > Benjamin Gaignard >=20 > Graphic Working Group >=20 > Linaro.org =E2=94=82 Open source software for ARM SoCs >=20 > Follow Linaro: Facebook | Twitter | Blog --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVp459AAoJEN0jrNd/PrOhimYP/jrDnVwO7gQpKrE8QEZrd/Ll XxqZlT3yVlBy3WzTMAueZxVVnheJYYzbpAxKn6cxtrxwCQmByzBI5Cm8nd37yYh7 FBEzl3e8Zu9R5LNQRQq2rFsbXCFkBNGqTnjRqLXizKi3vZTXDKZpHse15pJnQbzF Jd8q39wiGyM4Z2zIyS/6yNiLsd4RHSc/cyj5FiefIeRpcR/J7M6DtlGAVziBQk1I /mekOuI7q9Jg/mnuWS5WqDRaZDe4HAZs8icqwLbFJTdB+e88Ig4SiZTk1MfMjbr2 9hGxl6rM8DJw4p6NmlVwVjPc49S4RzMHIDct/MZXnYbcwf8HgOepePvUq/LBXJg9 Bj8iHgo35o6fDKiNrS/B77UnMx0YWDJbkX57+AecYbt26Tk2Y+ajkkNFWfHrbQcw BCQaJZ1oV9RSS9ZbfnFun8JUXqJZKt0fi5sz3AETmBY9oubEPasJEmwuBGlttxgS gHJKTJHBM8ZXBVZGrwUIfo4g9oWWrWPxNNM7c2BGduIomzH7D8KwLX/dJLx71sxO S4/wtniz4YV2SKu1A1pHyAwic8uJxQmktlZgfLczoaCvt+4jRX349Hb7xLEEmW4S WX1XwfH4hEKPT65Ck5N/f6jmTZ/Uzgxya6B8FOk1hQw+J4/pxwQ2MxOkug22Ct+k K/WGOhlfhfv/G7kxGB3o =nC2M -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd-- --===============0843393365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0843393365==--