From: Oleg Nesterov <oleg@redhat.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
Jeff Moyer <jmoyer@redhat.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 140/321] fs/built-in.o:undefined reference to `filemap_page_mkwrite'
Date: Thu, 16 Jul 2015 21:38:56 +0200 [thread overview]
Message-ID: <20150716193856.GA25255@redhat.com> (raw)
In-Reply-To: <20150716191258.GA22760@kvack.org>
On 07/16, Benjamin LaHaise wrote:
>
> On Thu, Jul 16, 2015 at 09:05:03PM +0200, Oleg Nesterov wrote:
> > Thanks!
> ...
> > but the problem looks clear: CONFIG_MMU is not set, so we need
> > a dummy filemap_page_mkwrite() along with generic_file_mmap() and
> > generic_file_readonly_mmap().
> >
> > I'll send the fix, but...
> >
> > Benjamin, Jeff, shouldn't AIO depend on MMU? Or it can actually work even
> > if CONFIG_MMU=n?
>
> It should work when CONFIG_MMU=n,
Really? I am just curious.
alloc_anon_inode() doesn't set S_IFREG, it seems that nommu.c:do_mmap_pgoff()
should just fail in validate_mmap_request() ?
Even if not, it should fail because of MAP_SHARED && !NOMMU_MAP_DIRECT?
I am just trying to understand, could you explain?
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-16 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 1:02 [mmotm:master 140/321] fs/built-in.o:undefined reference to `filemap_page_mkwrite' kbuild test robot
2015-07-16 19:05 ` Oleg Nesterov
2015-07-16 19:12 ` Benjamin LaHaise
2015-07-16 19:38 ` Oleg Nesterov [this message]
2015-07-16 19:45 ` Benjamin LaHaise
2015-07-16 20:03 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716193856.GA25255@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=jmoyer@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.