All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gcc: add gcc 5.2.0
Date: Thu, 16 Jul 2015 22:56:39 +0200	[thread overview]
Message-ID: <20150716225639.14772165@free-electrons.com> (raw)
In-Reply-To: <1437079928-9591-1-git-send-email-gustavo@zacarias.com.ar>

Dear Gustavo Zacarias,

On Thu, 16 Jul 2015 17:52:08 -0300, Gustavo Zacarias wrote:

> +	config BR2_GCC_VERSION_5_2_X
> +		bool "gcc 5.2.x"
> +		# Broken or unsupported architectures
> +		depends on !BR2_arc
> +		select BR2_GCC_NEEDS_MPC
> +		select BR2_GCC_SUPPORTS_GRAPHITE
> +
>  endchoice
>  
>  config BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE
> @@ -99,6 +106,7 @@ config BR2_GCC_VERSION
>  	default "4.8.5"     if BR2_GCC_VERSION_4_8_X
>  	default "4.9.3"     if BR2_GCC_VERSION_4_9_X
>  	default "5.1.0"     if BR2_GCC_VERSION_5_1_X
> +	default "5.2.0"     if BR2_GCC_VERSION_5_2_X

That's not the right way of adding gcc 5.2 support. The gcc
release numbers have changed: 5 is the major release, and 5.{1,2} are
the bug fix releases.

Quoting https://gcc.gnu.org/ml/gcc/2015-07/msg00198.html:

  GCC 5.2 is a bug-fix release from the GCC 5 branch
  containing important fixes for regressions and serious bugs in
  GCC 5.1 with more than 81 bugs fixed since the previous release.

Therefore, we should instead rename BR2_GCC_VERSION_5_1_X to
BR2_GCC_VERSION_5_X, and then simply update from 5.1 to 5.2 (keeping
only 5.2 and removing 5.1), exactly like we were doing when the version
was changed from 4.9.1 to 4.9.2 for example.

Could you rework your patch in this direction?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-16 20:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 20:52 [Buildroot] [PATCH] gcc: add gcc 5.2.0 Gustavo Zacarias
2015-07-16 20:56 ` Thomas Petazzoni [this message]
2015-07-16 20:59   ` Gustavo Zacarias
2015-07-16 21:10     ` Thomas Petazzoni
2015-07-16 21:14       ` Gustavo Zacarias
2015-07-16 21:30         ` Thomas Petazzoni
2015-07-17 14:31           ` Gustavo Zacarias
2015-07-17 14:32             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716225639.14772165@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.