From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frans Klaver <fransklaver@gmail.com>,
Antoine Schweitzer-Chaput <antoine@schweitzer-chaput.fr>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Koray Gulcu <koray.gulcu@ozu.edu.tr>,
Greg Donald <gdonald@gmail.com>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
Karthik Nayak <karthik.188@gmail.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v4] staging: rtl8192u: remove bool comparisons
Date: Fri, 17 Jul 2015 11:34:45 +0530 [thread overview]
Message-ID: <20150717060445.GA8422@sudip-PC> (raw)
In-Reply-To: <20150716134949.GA27865@goodgumbo.baconseed.org>
On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> Remove explicit true/false comparisons to bool variables.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
<snip>
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b852396..41cf99d 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -2043,16 +2043,10 @@ static bool GetNmodeSupportBySecCfg8192(struct net_device *dev)
>
> static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
> {
> - bool Reval;
> struct r8192_priv *priv = ieee80211_priv(dev);
> struct ieee80211_device *ieee = priv->ieee80211;
>
> - if (ieee->bHalfWirelessN24GMode == true)
> - Reval = true;
> - else
> - Reval = false;
> -
> - return Reval;
> + return ieee->bHalfWirelessN24GMode;
I think this should have been in a separate patch.
regards
sudip
next prev parent reply other threads:[~2015-07-17 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 13:49 [PATCH v4] staging: rtl8192u: remove bool comparisons Luis de Bethencourt
2015-07-17 6:04 ` Sudip Mukherjee [this message]
2015-07-17 9:07 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717060445.GA8422@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=antoine@schweitzer-chaput.fr \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=ebru.akagunduz@gmail.com \
--cc=fransklaver@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=karthik.188@gmail.com \
--cc=koray.gulcu@ozu.edu.tr \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=luis@debethencourt.com \
--cc=mahfouz.saif.elyazal@gmail.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.