From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG0h3-0008Vq-92 for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZG0gy-0006Cx-9v for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:08:29 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:38232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG0gx-0006C6-L6 for qemu-devel@nongnu.org; Fri, 17 Jul 2015 04:08:24 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Jul 2015 13:38:16 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 7CD3E1258061 for ; Fri, 17 Jul 2015 13:41:05 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6H87a7x41025692 for ; Fri, 17 Jul 2015 13:37:37 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6H6qcBF014126 for ; Fri, 17 Jul 2015 12:22:38 +0530 Date: Fri, 17 Jul 2015 13:37:19 +0530 From: Bharata B Rao Message-ID: <20150717080719.GF4827@in.ibm.com> References: <20150716045509.GC4827@in.ibm.com> <20150716103007.GE4827@in.ibm.com> <20150716142421.4478d67e@nial.brq.redhat.com> <55A8AE18.5070704@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A8AE18.5070704@redhat.com> Subject: Re: [Qemu-devel] memory hotplug fails with mem-merge option Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: Igor Mammedov , qemu-devel@nongnu.org, David Gibson On Fri, Jul 17, 2015 at 10:26:16AM +0300, Marcel Apfelbaum wrote: > On 07/16/2015 03:24 PM, Igor Mammedov wrote: > >On Thu, 16 Jul 2015 16:00:07 +0530 > >Bharata B Rao wrote: > > > >>On Thu, Jul 16, 2015 at 10:25:09AM +0530, Bharata B Rao wrote: > >>>Hi, > >>> > >>>When I use -machine pc,mem-merge=off|on -m 1G,slots=4,maxmem=2G, adding > >>>memory-backend-ram object fails like below. Same failure is seen with > >>>-machine pseries,mem-merge=on|off. > >>> > >>>(qemu) object_add memory-backend-ram,id=ram0,size=1G > >>> > >>>qemu-system-x86_64: util/qemu-option.c:388: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. > >> > >>Same failure seen with -machine pseries,mem-merge=off when used together with > >>-object memory-backend-file on QEMU commandline in which case boot time > >>failure is observed. > >> > >>Regards, > >>Bharata. > > > >looks like related to > > > >0a7cf217 util/qemu-config: fix regression of qmp_query_command_line_options > >and > >49d2e64 machine: remove qemu_machine_opts global list > > > >CCing Marcel in hope he knows how to fix it right away. > Hi, > > Can you please check that Eduardo's patch fixes this? > [PATCH] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init() > https://www.mail-archive.com/qemu-devel@nongnu.org/msg310915.html Yes, this fixes the problem. Regards, Bharata.