From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG3EX-00013X-1S for qemu-devel@nongnu.org; Fri, 17 Jul 2015 06:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZG3ES-00043V-9x for qemu-devel@nongnu.org; Fri, 17 Jul 2015 06:51:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG3ES-00043Q-4j for qemu-devel@nongnu.org; Fri, 17 Jul 2015 06:51:08 -0400 Date: Fri, 17 Jul 2015 11:51:04 +0100 From: "Daniel P. Berrange" Message-ID: <20150717105103.GE4835@redhat.com> References: <1436878300-13284-1-git-send-email-w.bumiller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1436878300-13284-1-git-send-email-w.bumiller@proxmox.com> Subject: Re: [Qemu-devel] [PATCH] vnc: fix vnc client authentication Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wolfgang Bumiller Cc: qemu-devel@nongnu.org On Tue, Jul 14, 2015 at 02:51:40PM +0200, Wolfgang Bumiller wrote: > Commit 800567a61 updated the code to the generic crypto API > and mixed up encrypt and decrypt functions in > procotol_client_auth_vnc. > (Used to be: deskey(key, EN0) which encrypts, and was > changed to qcrypto_cipher_decrypt in 800567a61.) > Changed it to qcrypto_cipher_encrypt now. > > Signed-off-by: Wolfgang Bumiller > --- > ui/vnc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index 94e4f19..1483958 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -2551,7 +2551,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len) > goto reject; > } > > - if (qcrypto_cipher_decrypt(cipher, > + if (qcrypto_cipher_encrypt(cipher, > vs->challenge, > response, > VNC_AUTH_CHALLENGE_SIZE, I see its already merged while i was on holiday, but none the less Reviewed-by: Daniel P. Berrange Thanks for fixing my stupid typo. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|