From: Vinod Koul <vinod.koul@intel.com>
To: David Henningsson <david.henningsson@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
libin.yang@intel.com,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Lin, Mengdong" <mengdong.lin@intel.com>
Subject: Re: HDMI hotplug on Skylake when power well is off
Date: Fri, 17 Jul 2015 16:44:29 +0530 [thread overview]
Message-ID: <20150717111429.GP5086@localhost> (raw)
In-Reply-To: <55A7B383.6020206@canonical.com>
On Thu, Jul 16, 2015 at 03:37:07PM +0200, David Henningsson wrote:
> +static void i915_audio_component_hotplug_notify(struct hdac_bus *bus,
> + const struct i915_audio_hotplug_info *info)
> +{
> + struct hda_codec *codec;
this should be hdac_device as core doesnt know hda_codec
> +
> + codec_dbg("Received HDMI hotplug callback (connector = %s, plugged in = %d)",
> + info->connector_name, (int) info->plugged_in);
> +
> + for (i = 0; i <= MAX_CODEC_ADDRESS; i++)
> + if (bus->caddr_tbl[i] && bus->caddr_tbl[i]->hotplug_notify)
> + bus->caddr_tbl[i]->hotplug_notify(bus->caddr_tbl[i], info);
> +}
Rest looks good :)
--
~Vinod
next prev parent reply other threads:[~2015-07-17 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 9:05 HDMI hotplug on Skylake when power well is off David Henningsson
2015-07-15 10:59 ` Takashi Iwai
2015-07-16 8:39 ` Vinod Koul
2015-07-16 9:34 ` David Henningsson
2015-07-16 10:02 ` Vinod Koul
2015-07-16 10:06 ` Takashi Iwai
2015-07-16 11:35 ` Vinod Koul
2015-07-16 12:21 ` Takashi Iwai
2015-07-16 13:37 ` David Henningsson
2015-07-16 13:57 ` Takashi Iwai
2015-07-17 11:17 ` Vinod Koul
2015-07-17 13:06 ` Takashi Iwai
2015-07-17 11:14 ` Vinod Koul [this message]
2015-07-17 13:05 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717111429.GP5086@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=libin.yang@intel.com \
--cc=mengdong.lin@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.