Re: [meta-networking][PATCH] opensaf: Add PACKAGECONFIG for openhpi

[Joe MacDonald <Joe_MacDonald@mentor.com>]

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

Hi Li,

[[oe] [meta-networking][PATCH] opensaf: Add PACKAGECONFIG for openhpi] On 15.07.17 (Fri 10:45) Li xin wrote:

> opensaf support for the HPI, So provide a PACKAGECONFIG option for openhpi
> 
> Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com>
> ---
>  meta-networking/recipes-daemons/opensaf/opensaf_4.5.0.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-networking/recipes-daemons/opensaf/opensaf_4.5.0.bb b/meta-networking/recipes-daemons/opensaf/opensaf_4.5.0.bb
> index 3d0175e..6ad8a3d 100644
> --- a/meta-networking/recipes-daemons/opensaf/opensaf_4.5.0.bb
> +++ b/meta-networking/recipes-daemons/opensaf/opensaf_4.5.0.bb
> @@ -36,6 +36,8 @@ USERADD_PARAM_${PN} =  "-r -g opensaf -d ${datadir}/opensaf/ -s ${sbindir}/nolog
>  SYSTEMD_SERVICE_${PN} += "opensafd.service plmcboot.service plmcd.service"
>  SYSTEMD_AUTO_ENABLE = "disable"
>  
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'openhpi', 'openhpi', '', d)}"

AFAIK this won't actually add openhpi to DEPENDS properly unless you are
explicitly defining a DISTRO_FEATURE for it.  But it will cause a bunch
of stuff to be rebuilt since PACKAGECONFIG is getting updated and
signatures will be invalidated.  Not a big deal, but still not quite
what you're hoping to accomplish, I think.

I was just testing a few other things on my current patch queue and have
a patch for this already, so I'm going to drop this patch for now.

Just for future reference, too, @base_contains is on the way out, you
should use @bb.utils.contains instead.

-J.

> +PACKAGECONFIG[openhpi] = "--with-hpi-interface=B03 --enable-ais-plm,,openhpi"
>  PACKAGECONFIG[systemd] = "--enable-systemd-daemon"
>  
>  do_configure_prepend () {
> -- 
> 1.8.4.2
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]