From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org, Dave Hansen <dave@sr71.net>
Cc: Andy Lutomirski <luto@amacapital.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave@sr71.net>, Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] x86/fpu, fork: Dynamically allocate 'struct fpu'
Date: Fri, 17 Jul 2015 21:23:48 +0200 [thread overview]
Message-ID: <20150717192348.GB24300@gmail.com> (raw)
In-Reply-To: <1437128892-9831-2-git-send-email-mingo@kernel.org>
* Ingo Molnar <mingo@kernel.org> wrote:
> From: Dave Hansen <dave@sr71.net>
>
> The FPU rewrite removed the dynamic allocations of 'struct fpu'.
> But, this potentially wastes massive amounts of memory (2k per
> task on systems that do not have AVX-512 for instance).
>
> Instead of having a separate slab, this patch just appends the
> space that we need to the 'task_struct' which we dynamically
> allocate already. This saves from doing an extra slab
> allocation at fork().
>
> The only real downside here is that we have to stick everything
> and the end of the task_struct. But, I think the BUILD_BUG_ON()s
> I stuck in there should keep that from being too fragile.
>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: dave@sr71.net
> Link: http://lkml.kernel.org/r/20150716191437.A334FF2E@viggo.jf.intel.com
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Dave, can I put your Signed-off-by into this patch? I have already tested these
two patches and they are looking good here - so unless you can see some breakage
or other problem I'd prefer it to keep it two patches.
Thanks,
Ingo
next prev parent reply other threads:[~2015-07-17 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 10:28 [PATCH 0/2] x86/fpu: Fix FPU context sizing boot regression, introduce dynamic task_struct Ingo Molnar
2015-07-17 10:28 ` [PATCH 1/2] x86/fpu, fork: Dynamically allocate 'struct fpu' Ingo Molnar
2015-07-17 19:23 ` Ingo Molnar [this message]
2015-07-17 20:30 ` Dave Hansen
2015-07-18 1:45 ` Ingo Molnar
2015-07-18 3:25 ` [tip:x86/urgent] x86/fpu, sched: Dynamically allocate 'struct fpu ' tip-bot for Dave Hansen
2015-07-17 10:28 ` [PATCH 2/2] x86/fpu, sched: Introduce CONFIG_ARCH_WANTS_DYNAMIC_TASK_STRUCT and use it on x86 Ingo Molnar
2015-07-17 17:02 ` Andy Lutomirski
2015-07-18 3:26 ` [tip:x86/urgent] " tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717192348.GB24300@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave@sr71.net \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.