From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC Date: Sat, 18 Jul 2015 01:47:37 +0200 Message-ID: <20150717234737.GJ3487@piout.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: S Twiss Cc: DEVICETREE , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXKERNEL , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Alessandro Zummo , David Dajun Chen , Lee Jones , Samuel Ortiz , Support Opensource List-Id: linux-input@vger.kernel.org On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > From: S Twiss > > Add device tree bindings for the DA9062 RTC driver component > > Signed-off-by: Steve Twiss > > --- > Checks performed with linux-next/next-20150708/scripts/checkpatch.pl > da9062.txt total: 0 errors, 0 warnings, 88 lines checked > This patch applies against linux-next and next-20150708 > > > Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt > index 5765ed9..38802b5 100644 > --- a/Documentation/devicetree/bindings/mfd/da9062.txt > +++ b/Documentation/devicetree/bindings/mfd/da9062.txt > @@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices: > Device Supply Names Description > ------ ------------ ----------- > da9062-regulator : : LDOs & BUCKs > +da9062-rtc : : Real-Time Clock > da9062-watchdog : : Watchdog Timer > > ====== > @@ -41,6 +42,10 @@ Sub-nodes: > Documentation/devicetree/bindings/regulator/regulator.txt > > > +- rtc : This node defines settings required for the Real-Time Clock associated > + with the DA9062. There are currently no entries in this binding, however > + compatible = "dlg,da9062-rtc" should be added if a node is created. > + > - watchdog: This node defines the settings for the watchdog driver associated > with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added > if a node is created. > @@ -55,6 +60,10 @@ Example: > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > > + rtc { > + compatible = "dlg,da9062-rtc"; > + }; > + Are those subnodes even parsed? As the parent node is not compatible with "simple-bus" or "simple-mfd", I guess not. You driver is probed from the mfd_cells in da9063-core.c > watchdog { > compatible = "dlg,da9062-watchdog"; > }; > -- > end-of-patch for PATCH RFC V1 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id q10si7200wiz.0.2015.07.17.16.47.38 for ; Fri, 17 Jul 2015 16:47:38 -0700 (PDT) Date: Sat, 18 Jul 2015 01:47:37 +0200 From: Alexandre Belloni To: S Twiss Cc: DEVICETREE , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXKERNEL , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Alessandro Zummo , David Dajun Chen , Lee Jones , Samuel Ortiz , Support Opensource Subject: [rtc-linux] Re: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC Message-ID: <20150717234737.GJ3487@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > From: S Twiss > > Add device tree bindings for the DA9062 RTC driver component > > Signed-off-by: Steve Twiss > > --- > Checks performed with linux-next/next-20150708/scripts/checkpatch.pl > da9062.txt total: 0 errors, 0 warnings, 88 lines checked > This patch applies against linux-next and next-20150708 > > > Documentation/devicetree/bindings/mfd/da9062.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/da9062.txt b/Documentation/devicetree/bindings/mfd/da9062.txt > index 5765ed9..38802b5 100644 > --- a/Documentation/devicetree/bindings/mfd/da9062.txt > +++ b/Documentation/devicetree/bindings/mfd/da9062.txt > @@ -5,6 +5,7 @@ DA9062 consists of a large and varied group of sub-devices: > Device Supply Names Description > ------ ------------ ----------- > da9062-regulator : : LDOs & BUCKs > +da9062-rtc : : Real-Time Clock > da9062-watchdog : : Watchdog Timer > > ====== > @@ -41,6 +42,10 @@ Sub-nodes: > Documentation/devicetree/bindings/regulator/regulator.txt > > > +- rtc : This node defines settings required for the Real-Time Clock associated > + with the DA9062. There are currently no entries in this binding, however > + compatible = "dlg,da9062-rtc" should be added if a node is created. > + > - watchdog: This node defines the settings for the watchdog driver associated > with the DA9062 PMIC. The compatible = "dlg,da9062-watchdog" should be added > if a node is created. > @@ -55,6 +60,10 @@ Example: > interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > > + rtc { > + compatible = "dlg,da9062-rtc"; > + }; > + Are those subnodes even parsed? As the parent node is not compatible with "simple-bus" or "simple-mfd", I guess not. You driver is probed from the mfd_cells in da9063-core.c > watchdog { > compatible = "dlg,da9062-watchdog"; > }; > -- > end-of-patch for PATCH RFC V1 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.