From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, alexander.duyck@gmail.com, davem@davemloft.net
Subject: Re: [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac
Date: Sat, 18 Jul 2015 06:46:41 +0200 [thread overview]
Message-ID: <20150718044641.GD30336@oracle.com> (raw)
In-Reply-To: <1437174422.2495.75.camel@perches.com>
On (07/17/15 16:07), Joe Perches wrote:
> On Fri, 2015-07-17 at 22:00 +0200, Sowmini Varadhan wrote:
> > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field,
> > which triggers unaligned access messages, so rearrange vxlan_fdb
> > to avoid this in the most non-intrusive way.
>
> What arch does this?
sparc.
BTW, I was also getting a lot of alignment errors from
vxlan_xmit_skb (vxh comes out unaligned) for the IPv6 path.
I did not have time to investigate/fix this correctly- not sure
if this is specific to v6.
--Sowmini
prev parent reply other threads:[~2015-07-18 4:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 20:00 [PATCHv2 RFC net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac Sowmini Varadhan
2015-07-17 23:07 ` Joe Perches
2015-07-18 1:18 ` David Miller
2015-07-18 18:06 ` Joe Perches
2015-07-19 5:23 ` David Miller
2015-07-19 12:01 ` Sowmini Varadhan
2015-07-19 18:38 ` David Miller
2015-07-19 19:07 ` Joe Perches
2015-07-18 4:46 ` Sowmini Varadhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150718044641.GD30336@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.