From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
Date: Sat, 18 Jul 2015 11:31:59 +0200 [thread overview]
Message-ID: <20150718113159.4c8da6ea@free-electrons.com> (raw)
In-Reply-To: <1437085987-4512-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Fri, 17 Jul 2015 00:33:07 +0200, Yann E. MORIN wrote:
> From: Guido Mart?nez <guido@vanguardiasur.com.ar>
>
> Commit bee5745c introduced an extra level of 'make' when the umask is
> different from 0022. However, when several targets were specified on
> the command line, a new make instance would be called for each target.
> This introduces a huge performance overhead when many targets are
> specified on the command line.
>
> To fix this, use the same approach as used in the mkmakefile script:
> an addition target on which the MAKECMDGOALS depend, so that this
> target is run only once.
>
> Note that the mkmakefile script contains a special exception for
> Makefile, because the Makefile in the output directory is generated.
> Since the top-level Makefile is not generated, this exception is not
> needed here.
>
> While we're at it, also fix the whitespace in the UMASK assignment.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> [yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>
> ---
> Changes v0 -> v4:
> - aggregate Arnout's and Guido's patches together, keepign the best of
> both patches
> - fix the spaces in UMASK assignment
> ---
> Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-18 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:33 [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling Yann E. MORIN
2015-07-16 22:35 ` Arnout Vandecappelle
2015-07-17 16:47 ` Yann E. MORIN
2015-07-18 9:31 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150718113159.4c8da6ea@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.