From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
benh@kernel.crashing.org, davem@davemloft.net
Subject: Re: [PATCH] iommu-common: Do not use 64 bit constant 0xffffffffffffffffl for computing align_mask
Date: Sun, 19 Jul 2015 22:41:42 +0200 [thread overview]
Message-ID: <20150719204142.GA9844@oracle.com> (raw)
In-Reply-To: <874mkzevz4.fsf@rasmusvillemoes.dk>
On (07/19/15 22:25), Rasmus Villemoes wrote:
>
> Wouldn't GENMASK(align_order-1, 0) work for all cases (assuming
> align_order has a sane value)?
Devices with limits on DMA masks are uncommon, so I'm personally
not an expert at all the variations in this space, but I was thinking
that this doing
align_mask = 0xffffffffffffffffull >> (64 - align_order);
would be the compact answer for both 32 and 64 bit cases here?
--Sowmini
next prev parent reply other threads:[~2015-07-19 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 12:20 [PATCH] iommu-common: Do not use 64 bit constant 0xffffffffffffffffl for computing align_mask Sowmini Varadhan
2015-07-19 15:27 ` Guenter Roeck
2015-07-19 20:25 ` Rasmus Villemoes
2015-07-19 20:41 ` Sowmini Varadhan [this message]
2015-07-20 1:58 ` Guenter Roeck
2015-07-20 17:57 ` Rasmus Villemoes
2015-07-20 19:25 ` Sowmini Varadhan
2015-07-20 23:28 ` Andrew Morton
2015-07-21 0:26 ` Guenter Roeck
2015-07-20 14:44 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150719204142.GA9844@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.