From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver Date: Sun, 19 Jul 2015 23:16:00 -0700 Message-ID: <20150720061559.GX17550@atomide.com> References: <1437166592-25378-1-git-send-email-d-gerlach@ti.com> <1437166592-25378-4-git-send-email-d-gerlach@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1437166592-25378-4-git-send-email-d-gerlach-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Gerlach Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jassi Brar , Santosh Shilimkar , Suman Anna , Keerthy List-Id: linux-omap@vger.kernel.org * Dave Gerlach [150717 13:59]: > + > +/* Public functions */ ... > +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type); > +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address); > +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status); > +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power); > +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power); I think you can avoid exporting these SoC specific functions by just exporting wkup_m3_request() and wkup_m3_free() type functions with a data structure containing the necessary function pointers. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Sun, 19 Jul 2015 23:16:00 -0700 Subject: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver In-Reply-To: <1437166592-25378-4-git-send-email-d-gerlach@ti.com> References: <1437166592-25378-1-git-send-email-d-gerlach@ti.com> <1437166592-25378-4-git-send-email-d-gerlach@ti.com> Message-ID: <20150720061559.GX17550@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Dave Gerlach [150717 13:59]: > + > +/* Public functions */ ... > +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type); > +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address); > +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status); > +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power); > +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power); I think you can avoid exporting these SoC specific functions by just exporting wkup_m3_request() and wkup_m3_free() type functions with a data structure containing the necessary function pointers. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755327AbbGTGQG (ORCPT ); Mon, 20 Jul 2015 02:16:06 -0400 Received: from muru.com ([72.249.23.125]:36457 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755107AbbGTGQD (ORCPT ); Mon, 20 Jul 2015 02:16:03 -0400 Date: Sun, 19 Jul 2015 23:16:00 -0700 From: Tony Lindgren To: Dave Gerlach Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Jassi Brar , Santosh Shilimkar , Suman Anna , Keerthy Subject: Re: [PATCH v2 3/3] soc: ti: Add wkup_m3_ipc driver Message-ID: <20150720061559.GX17550@atomide.com> References: <1437166592-25378-1-git-send-email-d-gerlach@ti.com> <1437166592-25378-4-git-send-email-d-gerlach@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437166592-25378-4-git-send-email-d-gerlach@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dave Gerlach [150717 13:59]: > + > +/* Public functions */ ... > +EXPORT_SYMBOL_GPL(wkup_m3_set_mem_type); > +EXPORT_SYMBOL_GPL(wkup_m3_set_resume_address); > +EXPORT_SYMBOL_GPL(wkup_m3_request_pm_status); > +EXPORT_SYMBOL_GPL(wkup_m3_prepare_low_power); > +EXPORT_SYMBOL_GPL(wkup_m3_finish_low_power); I think you can avoid exporting these SoC specific functions by just exporting wkup_m3_request() and wkup_m3_free() type functions with a data structure containing the necessary function pointers. Regards, Tony