From: Martin Kletzander <mkletzan@redhat.com>
To: Frediano Ziglio <fziglio@redhat.com>
Cc: peter.maydell@linaro.org, pkrempa@redhat.com,
libvir-list@redhat.com, qemu-devel@nongnu.org,
cfergeau@redhat.com, pgrunt@redhat.com, kraxel@redhat.com,
spice-devel@lists.freedesktop.org
Subject: Re: [Qemu-devel] [libvirt] [PATCH] qxl: Fix new function name for spice-server library
Date: Mon, 20 Jul 2015 11:46:49 +0200 [thread overview]
Message-ID: <20150720094645.GG3887@wheatley> (raw)
In-Reply-To: <1437381803-2936-1-git-send-email-fziglio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
>The new spice-server function to limit the number of monitors (0.12.6)
>changed while development from spice_qxl_set_monitors_config_limit to
>spice_qxl_max_monitors (accepted upstream).
>By mistake I post patch with former name.
>This patch fix the function name.
>
>Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
>
>---
> hw/display/qxl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>I tested again doing a clean build, unfortunately I did some mistake
>and my tests worked.
>
>diff --git a/hw/display/qxl.c b/hw/display/qxl.c
>index 4e5ff69..2288238 100644
>--- a/hw/display/qxl.c
>+++ b/hw/display/qxl.c
>@@ -273,8 +273,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice *qxl, int replay)
> } else {
> #if SPICE_SERVER_VERSION >= 0x000c06 /* release 0.12.6 */
> if (qxl->max_outputs) {
>- spice_qxl_set_monitors_config_limit(&qxl->ssd.qxl,
>- qxl->max_outputs);
>+ spice_qxl_set_max_monitors(&qxl->ssd.qxl, qxl->max_outputs);
> }
> #endif
> qxl->guest_monitors_config = qxl->ram->monitors_config;
>--
>2.1.0
>
Same as the fix I did in order for this to work with upstream spice.
ACK. Weak, though, as I'm not a privileged one.
Martin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-20 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 8:43 [Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library Frediano Ziglio
2015-07-20 8:51 ` Christophe Fergeau
2015-07-20 9:46 ` Martin Kletzander [this message]
2015-07-22 14:37 ` [Qemu-devel] [Spice-devel] [libvirt] " Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720094645.GG3887@wheatley \
--to=mkletzan@redhat.com \
--cc=cfergeau@redhat.com \
--cc=fziglio@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pgrunt@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.