From: David Sterba <dsterba@suse.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org, clm@fb.com
Subject: Re: [PATCH] btrfs: its btrfs_err() instead of btrfs_error()
Date: Mon, 20 Jul 2015 13:33:42 +0200 [thread overview]
Message-ID: <20150720113342.GL6306@suse.cz> (raw)
In-Reply-To: <1437147923-23965-1-git-send-email-anand.jain@oracle.com>
On Fri, Jul 17, 2015 at 11:45:23PM +0800, Anand Jain wrote:
> sorry I indented to use btrfs_err() and I have no idea
> how btrfs_error() got there.
> infact I was thinking about these kind of oversights
> since these two func are too closely named.
Indeed, it's confusing. I suggest to convert btrfs_errror to
btrfs_std_error and change the prototype to
#define btrfs_std_error(fs_info, errno, fmt, args...)
and switch all btrfs_error users to pass NULL for 'fmt'.
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2015-07-20 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 15:45 [PATCH] btrfs: its btrfs_err() instead of btrfs_error() Anand Jain
2015-07-19 3:25 ` Liu Bo
2015-07-20 11:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720113342.GL6306@suse.cz \
--to=dsterba@suse.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.