From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: block: make /sys/block/<dev>/queue/discard_max_bytes writeable
Date: Mon, 20 Jul 2015 14:59:09 +0000 [thread overview]
Message-ID: <20150720145909.GA1765@mwanda> (raw)
In-Reply-To: <55AD0CA2.30400@fb.com>
Hello Jens Axboe,
The patch d45a0f150e9d: "block: make
/sys/block/<dev>/queue/discard_max_bytes writeable" from Jul 16,
2015, leads to the following static checker warning:
block/blk-sysfs.c:152 queue_discard_max_hw_show()
warn: should 'q->limits.max_hw_discard_sectors << 9' be a 64 bit type?
block/blk-sysfs.c
148 static ssize_t queue_discard_max_hw_show(struct request_queue *q, char *page)
149 {
150 unsigned long long val;
151
152 val = q->limits.max_hw_discard_sectors << 9;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It definitely looks like this can wrap.
153 return sprintf(page, "%llu\n", val);
154 }
regards,
dan carpenter
prev parent reply other threads:[~2015-07-20 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:58 block: make /sys/block/<dev>/queue/discard_max_bytes writeable Jens Axboe
2015-07-20 14:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720145909.GA1765@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.