From: Juergen Borleis <jbe@pengutronix.de>
To: kernel@pengutronix.de
Cc: Peter Hurley <peter@hurleysoftware.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use
Date: Mon, 20 Jul 2015 15:18:58 +0200 [thread overview]
Message-ID: <201507201518.58720.jbe@pengutronix.de> (raw)
In-Reply-To: <55ACF0E5.6040107@hurleysoftware.com>
Hi Peter,
On Monday 20 July 2015 15:00:21 Peter Hurley wrote:
> [...]
> > mxs_auart_reset() is a bad name from the beginning. But I just wanted to
> > keep this change small and only change things that are really required. I
> > will try with a V4.
>
> ISTM this should be split into 2 or 3 separate patches:
> 1. Rename mxs_auart_reset()
> 2. Fix stale rx on re-open
> 3. Reset @ probe
Okay.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: jbe@pengutronix.de (Juergen Borleis)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use
Date: Mon, 20 Jul 2015 15:18:58 +0200 [thread overview]
Message-ID: <201507201518.58720.jbe@pengutronix.de> (raw)
In-Reply-To: <55ACF0E5.6040107@hurleysoftware.com>
Hi Peter,
On Monday 20 July 2015 15:00:21 Peter Hurley wrote:
> [...]
> > mxs_auart_reset() is a bad name from the beginning. But I just wanted to
> > keep this change small and only change things that are really required. I
> > will try with a V4.
>
> ISTM this should be split into 2 or 3 separate patches:
> 1. Rename mxs_auart_reset()
> 2. Fix stale rx on re-open
> 3. Reset @ probe
Okay.
Regards,
Juergen
--
Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| Juergen Borleis ? ? ? ? ? ? |
Industrial Linux Solutions ? ? ? ? ? ? ? ? ? ?| http://www.pengutronix.de/ ?|
next prev parent reply other threads:[~2015-07-20 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 7:40 [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use Juergen Borleis
2015-07-16 7:40 ` Juergen Borleis
2015-07-16 15:36 ` Stefan Wahren
2015-07-16 15:36 ` Stefan Wahren
2015-07-17 13:10 ` Peter Hurley
2015-07-17 13:10 ` Peter Hurley
2015-07-17 14:35 ` Philipp Zabel
2015-07-17 14:35 ` Philipp Zabel
2015-07-20 8:04 ` Juergen Borleis
2015-07-20 8:04 ` Juergen Borleis
2015-07-20 13:00 ` Peter Hurley
2015-07-20 13:00 ` Peter Hurley
2015-07-20 13:18 ` Juergen Borleis [this message]
2015-07-20 13:18 ` Juergen Borleis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201507201518.58720.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.