From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: zforce - don't invert the interrupt GPIO
Date: Mon, 20 Jul 2015 09:55:19 -0700 [thread overview]
Message-ID: <20150720165519.GB30252@dtor-ws> (raw)
In-Reply-To: <1437396997-3182-2-git-send-email-dirk.behme@de.bosch.com>
On Mon, Jul 20, 2015 at 02:56:34PM +0200, Dirk Behme wrote:
> Commit 2d53809594af ("Input: zforce_ts - convert to use the gpiod
> interface") converted this driver to use the gpiod functions. These
> functions take the active low property into account, so we don't have
> to invert the result of gpiod_get_value_cansleep(). This has been
> missed in that commit. Fix it.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/zforce_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c
> index 32749db..edf01c3 100644
> --- a/drivers/input/touchscreen/zforce_ts.c
> +++ b/drivers/input/touchscreen/zforce_ts.c
> @@ -510,7 +510,7 @@ static irqreturn_t zforce_irq_thread(int irq, void *dev_id)
> if (!ts->suspending && device_may_wakeup(&client->dev))
> pm_stay_awake(&client->dev);
>
> - while (!gpiod_get_value_cansleep(ts->gpio_int)) {
> + while (gpiod_get_value_cansleep(ts->gpio_int)) {
> ret = zforce_read_packet(ts, payload_buffer);
> if (ret < 0) {
> dev_err(&client->dev,
> --
> 2.3.4
>
--
Dmitry
next prev parent reply other threads:[~2015-07-20 16:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:56 [PATCH 0/4 v2] Input: zforce - update interrupt handling Dirk Behme
2015-07-20 12:56 ` [PATCH 1/4] Input: zforce - don't invert the interrupt GPIO Dirk Behme
2015-07-20 16:55 ` Dmitry Torokhov [this message]
2015-07-20 12:56 ` [PATCH 2/4] Input: zforce - swap reset and " Dirk Behme
2015-07-24 21:32 ` Dmitry Torokhov
2015-07-25 5:19 ` Dirk Behme
2015-07-27 8:12 ` Dirk Behme
2015-07-27 21:17 ` Dmitry Torokhov
2015-07-28 8:29 ` Dirk Behme
2015-07-27 21:18 ` Dmitry Torokhov
2015-07-20 12:56 ` [PATCH 3/4 v2] Input: zforce - make the interrupt GPIO optional Dirk Behme
2015-07-20 12:56 ` [PATCH 4/4 v2] Input: zforce - enable irq only if we are ready to process it Dirk Behme
2015-07-21 8:47 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720165519.GB30252@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.