From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] autobuild - acpid does not build against musl
Date: Mon, 20 Jul 2015 21:52:53 +0300 [thread overview]
Message-ID: <20150720185253.GR13027@tarshish> (raw)
In-Reply-To: <1437417346-18621-1-git-send-email-brendanheading@gmail.com>
Hi Brendan,
On Mon, Jul 20, 2015 at 07:35:46PM +0100, Brendan Heading wrote:
> Fixes http://autobuild.buildroot.net/results/33e/33ef25e4707a5b81083204e0f064570c11d88af6/
Please spare a few words on what this patch is doing.
Also, your sign-off is missing.
> ---
> package/acpid/0003-fix-TEMP_FAILURE_RETRY.patch | 76 +++++++++++++++++++++++++
> package/acpid/0004-fix-warnings.patch | 38 +++++++++++++
> 2 files changed, 114 insertions(+)
> create mode 100644 package/acpid/0003-fix-TEMP_FAILURE_RETRY.patch
> create mode 100644 package/acpid/0004-fix-warnings.patch
>
> diff --git a/package/acpid/0003-fix-TEMP_FAILURE_RETRY.patch b/package/acpid/0003-fix-TEMP_FAILURE_RETRY.patch
> new file mode 100644
> index 0000000..7d81b3c
> --- /dev/null
> +++ b/package/acpid/0003-fix-TEMP_FAILURE_RETRY.patch
> @@ -0,0 +1,76 @@
> +Add missing TEMP_FAILURE_RETRY.
> +
> +Some external toolchains using strange C libraries (eg MUSL) do not define
> +this macro.
What is the upstream status of this patch?
> +
> +Signed-off-by : Brendan Heading <brendanheading@gmail.com>
[snip]
> diff --git a/package/acpid/0004-fix-warnings.patch b/package/acpid/0004-fix-warnings.patch
> new file mode 100644
> index 0000000..3c6a89d
> --- /dev/null
> +++ b/package/acpid/0004-fix-warnings.patch
Does this patch fix build failure or correctness? Buildroot generally doesn't
carry warning fix only patches.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-07-20 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 18:35 [Buildroot] [PATCH] autobuild - acpid does not build against musl Brendan Heading
2015-07-20 18:52 ` Baruch Siach [this message]
2015-07-20 19:15 ` Brendan Heading
2015-07-20 20:41 ` Thomas Petazzoni
2015-07-21 0:16 ` Brendan Heading
2015-07-21 7:26 ` Thomas Petazzoni
2015-07-21 12:15 ` Brendan Heading
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720185253.GR13027@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.