From: Dan Carpenter <dan.carpenter@oracle.com>
To: kuninori.morimoto.gx@renesas.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: rsnd: show debug message for SSI/SRC/DVC connection
Date: Tue, 21 Jul 2015 00:45:40 +0300 [thread overview]
Message-ID: <20150720214540.GA22293@mwanda> (raw)
Hello Kuninori Morimoto,
This is a semi-automatic email about new static checker warnings.
The patch 84e95355602c: "ASoC: rsnd: show debug message for
SSI/SRC/DVC connection" from Jul 15, 2015, leads to the following
Smatch complaint:
sound/soc/sh/rcar/core.c:338 rsnd_dai_connect()
warn: variable dereferenced before check 'mod' (see line 335)
sound/soc/sh/rcar/core.c
334 {
335 struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
^^^^^^^^^^^^^^^^^^^^^
Patch adds new dereference.
336 struct device *dev = rsnd_priv_to_dev(priv);
337
338 if (!mod)
^^^^
Existing code assumed "mod" could be NULL.
339 return -EIO;
340
regards,
dan carpenter
next reply other threads:[~2015-07-20 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 21:45 Dan Carpenter [this message]
2015-07-21 0:03 ` [PATCH] ASoC: rsnd: tidyup parameter assignment position Kuninori Morimoto
2015-07-21 10:49 ` Applied "ASoC: rsnd: tidyup parameter assignment position" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720214540.GA22293@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.