All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de,
	akpm@linux-foundation.org, jkosina@suse.cz, vgoyal@redhat.com,
	linux-kernel@vger.kernel.org, yinghai@kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH v2] Do not reserve crashkernel high memory if crashkernel low memory reserving failed
Date: Tue, 21 Jul 2015 09:38:14 +0200	[thread overview]
Message-ID: <20150721073814.GA17513@gmail.com> (raw)
In-Reply-To: <20150721073123.GA30649@dhcp-129-220.nay.redhat.com>


* Dave Young <dyoung@redhat.com> wrote:

> Hi, Baoquan
> 
> The interface was introduced by Yinghai, ccing him.

Also, why was this syntax introduced in the first place? Why should the user 
care??

We should only have a single crashkernel option, to enable it - and everything 
else should be figured out by the kernel, automatically.

Any other sub-options just paper over some fragility elsewhere and make the 
feature harder to use, hence more fragile.

Thanks,

	Ingo

  reply	other threads:[~2015-07-21  7:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 11:07 [PATCH] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Baoquan He
2015-07-19 13:40 ` Borislav Petkov
2015-07-19 14:23   ` Baoquan He
2015-07-19 14:53 ` [PATCH v2] " Baoquan He
2015-07-21  7:31   ` Dave Young
2015-07-21  7:38     ` Ingo Molnar [this message]
2015-07-21  8:19       ` Dave Young
2015-07-22  1:13       ` Baoquan He
2015-07-27 14:45       ` Joerg Roedel
2015-07-21  7:50     ` Baoquan He
2015-07-21  8:23       ` Dave Young
2015-07-21  8:58         ` Baoquan He
2015-07-21 19:22           ` Yinghai Lu
2015-07-22  0:59             ` Baoquan He
2015-07-22 23:47               ` Yinghai Lu
2015-07-28  0:52                 ` Baoquan He
2015-07-28  2:45                   ` Yinghai Lu
2015-07-28  9:19                     ` Baoquan He
2015-07-22  4:47             ` Minfei Huang
2015-07-22 23:44               ` Yinghai Lu
2015-07-22 10:11             ` Joerg Roedel
2015-07-22 23:41               ` Yinghai Lu
2015-07-27 14:03                 ` Joerg Roedel
2015-07-27 18:31     ` Yinghai Lu
2015-07-27 23:32       ` Baoquan He
2015-07-27 14:41   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150721073814.GA17513@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@suse.de \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.