From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753492AbbGUICO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 04:02:14 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:36357 "EHLO
	mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753431AbbGUICJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 04:02:09 -0400
Date: Tue, 21 Jul 2015 10:02:03 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Michal Marek <mmarek@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        x86@kernel.org, live-patching@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] x86/stackvalidate: Compile-time stack validation
Message-ID: <20150721080203.GB26811@gmail.com>
References: <cover.1436893563.git.jpoimboe@redhat.com>
 <c6ce1f45365e13dad73d4a04e100921b79794690.1436893563.git.jpoimboe@redhat.com>
 <CADWwUUZkfRL2RpGF3D-gjZjtLwrg=ip4duBqCTYV8jT8bQoNXA@mail.gmail.com>
 <20150720175026.GC28075@treble.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150720175026.GC28075@treble.redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> > > +int main(int argc, char *argv[])
> > > +{
> > > +       struct elf *elf;
> > > +       int ret = 0, warnings = 0;
> > > +
> > > +       argp_parse(&argp, argc, argv, 0, 0, &args);
> > > +
> > > +       elf = elf_open(args.args[0]);
> > > +       if (!elf) {
> > > +               fprintf(stderr, "error reading elf file %s\n", args.args[0]);
> > > +               return 1;
> > > +       }
> > > +
> > > +       ret = decode_sections(elf);
> > > +       if (ret < 0)
> > > +               goto out;
> > > +       warnings += ret;
> > > +
> > > +       ret = validate_functions(elf);
> > > +       if (ret < 0)
> > > +               goto out;
> > > +       warnings += ret;
> > > +
> > > +       ret = validate_uncallable_instructions(elf);
> > > +       if (ret < 0)
> > > +               goto out;
> > > +       warnings += ret;
> > > +
> > > +out:
> > 
> > elf_close(elf);  ??
> 
> I intentionally left out the call to elf_close() here, since this is the
> exit path and the kernel will free the memory anyway.

OTOH it makes Valgrind runs harder to interpret, as real leaks won't be visible.

So I'd only do intentional leaks only if it's truly, measurably improves 
performance.

Thanks,

	Ingo