From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] ASoC: max98925: reading beyond the end of the array Date: Tue, 21 Jul 2015 13:57:43 +0300 Message-ID: <20150721105743.GO5422@mwanda> References: <20150721085527.GA22070@mwanda> <20150721104350.GP11162@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id BA96D26071F for ; Tue, 21 Jul 2015 12:57:52 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20150721104350.GP11162@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Krzysztof Kozlowski , Lars-Peter Clausen , Axel Lin , alsa-devel@alsa-project.org, Liam Girdwood , Anish Kumar , kernel-janitors@vger.kernel.org, Takashi Iwai List-Id: alsa-devel@alsa-project.org On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote: > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote: > > Debug prints are seldom useful and this one has an annoying thing where > > it reads one space beyond the end of the array on error. > > It's a pretty big stretch to say that debug prints are rarely useful... I asked Anish if it was worth fixing and he said to delete it. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 21 Jul 2015 10:57:43 +0000 Subject: Re: [patch] ASoC: max98925: reading beyond the end of the array Message-Id: <20150721105743.GO5422@mwanda> List-Id: References: <20150721085527.GA22070@mwanda> <20150721104350.GP11162@sirena.org.uk> In-Reply-To: <20150721104350.GP11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mark Brown Cc: Krzysztof Kozlowski , Lars-Peter Clausen , Axel Lin , alsa-devel@alsa-project.org, Liam Girdwood , Anish Kumar , kernel-janitors@vger.kernel.org, Takashi Iwai On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote: > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote: > > Debug prints are seldom useful and this one has an annoying thing where > > it reads one space beyond the end of the array on error. > > It's a pretty big stretch to say that debug prints are rarely useful... I asked Anish if it was worth fixing and he said to delete it. regards, dan carpenter