From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] tests: modetest: Accept connector names in addition to connector IDs Date: Tue, 21 Jul 2015 17:10:38 +0200 Message-ID: <20150721151037.GA8710@ulmo.nvidia.com> References: <1437411380-10015-1-git-send-email-laurent.pinchart@ideasonboard.com> <20150721090557.GD20388@ulmo.nvidia.com> <1654438.IO0sSDc4rx@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1357756844==" Return-path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77B906E965 for ; Tue, 21 Jul 2015 08:11:01 -0700 (PDT) In-Reply-To: <1654438.IO0sSDc4rx@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1357756844== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 21, 2015 at 03:27:25PM +0300, Laurent Pinchart wrote: > Hi Thierry, >=20 > On Tuesday 21 July 2015 11:05:59 Thierry Reding wrote: > > On Mon, Jul 20, 2015 at 07:56:20PM +0300, Laurent Pinchart wrote: > > > From: Thierry Reding > > >=20 > > > Allow connector names to be used in the specification of the -s optio= n. > > > This requires storing the string passed on the command-line so that it > > > can later be resolved to a connector ID (after the DRM device has been > > > opened). > > >=20 > > > Connector names are constructed from the connector type name and > > > connector type ID using the same format as used internally in the > > > Linux kernel. > > >=20 > > > Signed-off-by: Thierry Reding > > > Signed-off-by: Laurent Pinchart > > > --- > > >=20 > > > tests/modetest/modetest.c | 94 ++++++++++++++++++++++++++++++++++++-= ----- > > > 1 file changed, 82 insertions(+), 12 deletions(-) > > >=20 > > > I've carried this patch in my tree for too long and I'm now tired of > > > rebasing it. It's thus time to get it in mainline. > > >=20 > > > Compared to the original version developed by Thierry, I've > > >=20 > > > - rebased the patch on top of latest master > > > - dropped dependencies on other WIP patches in Thierry's tree > > > - fixed printf alignment > > > - used asprintf to simplify name string allocation > > > - constructed the connector name using the same format as the Linux k= ernel > >=20 > > Heh, I started to get all these patches into shape last week, and this > > will probably give me more rebase headaches. >=20 > It shouldn't hurt too much as rebasing your patch on top of the master br= anch=20 > without any other dependency was pretty easy. >=20 > > But I guess that's what I deserve for letting things slide... >=20 > Should I consider this as an Acked-by ? :-) I don't think you need it since I authored it, but yeah, if this works, just go ahead and I'll figure out what to do about it when rebasing on top of your version. Thierry --gKMricLos+KVdGMg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVrmDqAAoJEN0jrNd/PrOhMiIQAL2qjc8uGu1kTckJlpAsn0/h yW5wuWFy95VzxiZl4Nc+f9cm5ovwa8UHUXCHPl+5JxFKqMsvhnWSANLow72dL0Xq Cmg+ru+uzKVx6bM3BUqpQoyG/l8uTBDKWJFVPz14b2VVFPs8gvBscpDbcXtLYy4H G/dfiBWIcpVEm+7GKcM27oQDfRsIabOPKuZEc5xyGj2dICgslAcqJbcOJVmqWn5J bZ8piGSKqeOiarMc1NsS7PBoxPugFLsFus62BOfjjxI9EW7Cb9BkQftI7sbPnlYg HOxYp3vVGqeNADp12IybYKLgwsvnhHaPxEuiFsSlJWn2qMDRlNtw7GQ+g0ERXTGu 2iLp31SnshjBl+EtVWDtjexiIrqg03Ivw8YcH7/AMZS9cFbXoeYxTriCD71FLcbI v1YBsrZhLVi/f0EGVF660pwVjHLj1+Obfz1wp/2R7NAYqHjIKI/MVGXZaIZpCO4J vSoKebHfJLTda5uavz+4Q9BhWita3xrvcahmAfNiaZrycRh1ijfnF0GrogQgAxwK oPAmX4uLN4YRFeiSo99p5xTuVS64rDgf/JBnbiafrG+nBh1tNz6unr8LIdOluBln O0hcngw3LZp5B3WAzkakFnMCdyWZCVSkmLTiFyFpn9/IRfzGe3EQtMgU06w3hSYb U3BtVPdxUIPYCDEZYgKj =C9kt -----END PGP SIGNATURE----- --gKMricLos+KVdGMg-- --===============1357756844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1357756844==--