* [PATCH 4.0 00/58] 4.0.9-stable review
@ 2015-07-19 19:10 Greg Kroah-Hartman
2015-07-20 3:17 ` Guenter Roeck
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-19 19:10 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, torvalds, akpm, linux, shuah.kh, stable
This is the start of the stable review cycle for the 4.0.9 release.
There are 58 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.0.9-rc1.gz
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linux 4.0.9-rc1
Frodo Lai <frodo.lai@gmail.com>
Input: pixcir_i2c_ts - fix receive error
Zhichang Yuan <yuanzhichang@hisilicon.com>
of/pci: Fix pci_address_to_pio() conversion of CPU address to I/O port
Alex Williamson <alex.williamson@redhat.com>
PCI: pciehp: Wait for hotplug command completion where necessary
Yinghai Lu <yinghai@kernel.org>
PCI: Add pci_bus_addr_t
Rafael J. Wysocki <rafael.j.wysocki@intel.com>
PCI: Propagate the "ignore hotplug" setting to parent
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
mtd: dc21285: use raw spinlock functions for nw_gpio_lock
Brian Norris <computersforpeace@gmail.com>
mtd: fix: avoid race condition when accessing mtd->usecount
Grygorii Strashko <Grygorii.Strashko@linaro.org>
leds / PM: fix hibernation on arm when gpio-led used with CPU led trigger
Liu Ying <Ying.Liu@freescale.com>
video: mxsfb: Make sure axi clock is enabled when accessing registers
Axel Lin <axel.lin@ingics.com>
genirq: devres: Fix testing return value of request_any_context_irq()
Bart Van Assche <bart.vanassche@sandisk.com>
IB/srp: Fix reconnection failure handling
Bart Van Assche <bart.vanassche@sandisk.com>
IB/srp: Fix connection state tracking
Bart Van Assche <bart.vanassche@sandisk.com>
IB/srp: Fix a connection setup race
Bart Van Assche <bart.vanassche@sandisk.com>
IB/srp: Remove an extraneous scsi_host_put() from an error path
Bart Van Assche <bart.vanassche@sandisk.com>
scsi_transport_srp: Fix a race condition
Bart Van Assche <bart.vanassche@sandisk.com>
scsi_transport_srp: Introduce srp_wait_for_queuecommand()
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
spi: pl022: Specify 'num-cs' property as required in devicetree binding
Gregory CLEMENT <gregory.clement@free-electrons.com>
spi: orion: Fix maximum baud rates for Armada 370/XP
Martin Sperl <kernel@martin.sperl.org>
spi: fix race freeing dummy_tx/rx before it is unmapped
Miroslav Benes <mbenes@suse.cz>
livepatch: add module locking around kallsyms calls
Stefan Wahren <stefan.wahren@i2se.com>
regulator: core: fix constraints output buffer
Joe Perches <joe@perches.com>
regulator: max77686: fix gpio_enabled shift wrapping bug
Maxime Coquelin <maxime.coquelin@st.com>
regmap: Fix possible shift overflow in regmap_field_init()
Arun Chandran <achandran@mvista.com>
regmap: Fix regmap_bulk_read in BE mode
Sagi Grimberg <sagig@mellanox.com>
iser-target: release stale iser connections
Vlastimil Babka <vbabka@suse.cz>
mm, thp: respect MPOL_PREFERRED policy with non-local node
Larry Finger <Larry.Finger@lwfinger.net>
mm: kmemleak_alloc_percpu() should follow the gfp from per_alloc()
Catalin Marinas <catalin.marinas@arm.com>
mm: kmemleak: allow safe memory scanning during kmemleak disabling
Will Deacon <will.deacon@arm.com>
arm64: vdso: work-around broken ELF toolchains in Makefile
Dave P Martin <Dave.Martin@arm.com>
arm64: mm: Fix freeing of the wrong memmap entries with !SPARSEMEM_VMEMMAP
Mark Rutland <mark.rutland@arm.com>
arm64: entry: fix context tracking for el0_sp_pc
Catalin Marinas <catalin.marinas@arm.com>
arm64: Do not attempt to use init_mm in reset_context()
Tomas Winkler <tomas.winkler@intel.com>
mei: txe: reduce suspend/resume time
Alexander Usyskin <alexander.usyskin@intel.com>
mei: me: wait for power gating exit confirmation
Vineet Gupta <vgupta@synopsys.com>
ARC: add compiler barrier to LLSC based cmpxchg
Vineet Gupta <vgupta@synopsys.com>
ARC: add smp barriers around atomics per Documentation/atomic_ops.txt
Arnaldo Carvalho de Melo <acme@kernel.org>
tools selftests: Fix 'clean' target with make 3.81
Antonio Ospite <ao2@ao2.it>
iio: accel: kxcjk-1013: add the "KXCJ9000" ACPI id
Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI / PM: Add missing pm_generic_complete() invocation
Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI / init: Switch over platform to the ACPI mode later
Takashi Iwai <tiwai@suse.de>
ALSA: hda - Fix the dock headphone output on Fujitsu Lifebook E780
Takashi Iwai <tiwai@suse.de>
ALSA: hda - Add headset support to Acer Aspire V5
Alex Deucher <alexander.deucher@amd.com>
ALSA: hda - set proper caps for newer AMD hda audio in KB/KV
David Henningsson <david.henningsson@canonical.com>
ALSA: hda - Fix Dock Headphone on Thinkpad X250 seen as a Line Out
Takashi Iwai <tiwai@suse.de>
ALSA: pcm: Fix pcm_class sysfs output
Ryan Underwood <nemesis@icequake.net>
Disable write buffering on Toshiba ToPIC95
Brian King <brking@linux.vnet.ibm.com>
ipr: Increase default adapter init stage change timeout
Paul E. McKenney <paulmck@linux.vnet.ibm.com>
rcu: Correctly handle non-empty Tiny RCU callback list with none ready
Aaron Lu <aaron.lu@intel.com>
gpio: crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
Eric W. Biederman <ebiederm@xmission.com>
sysfs: Create mountpoints with sysfs_create_mount_point
Eric W. Biederman <ebiederm@xmission.com>
mnt: Modify fs_fully_visible to deal with locked ro nodev and atime
Eric W. Biederman <ebiederm@xmission.com>
mnt: Refactor the logic for mounting sysfs and proc in a user namespace
Eric W. Biederman <ebiederm@xmission.com>
mnt: Update fs_fully_visible to test for permanently empty directories
Eric W. Biederman <ebiederm@xmission.com>
sysfs: Add support for permanently empty directories to serve as mount points.
Eric W. Biederman <ebiederm@xmission.com>
kernfs: Add support for always empty directories.
Eric W. Biederman <ebiederm@xmission.com>
proc: Allow creating permanently empty directories that serve as mount points
Eric W. Biederman <ebiederm@xmission.com>
sysctl: Allow creating permanently empty directories that serve as mountpoints.
Eric W. Biederman <ebiederm@xmission.com>
fs: Add helper functions for permanently empty directories.
-------------
Diffstat:
Documentation/DMA-API-HOWTO.txt | 29 ++++---
Documentation/DMA-API.txt | 30 +++----
.../devicetree/bindings/spi/spi_pl022.txt | 2 +-
Makefile | 4 +-
arch/arc/include/asm/atomic.h | 21 +++++
arch/arc/include/asm/bitops.h | 19 +++++
arch/arc/include/asm/cmpxchg.h | 26 +++++-
arch/arc/include/asm/spinlock.h | 32 ++++++++
arch/arm64/kernel/entry.S | 1 +
arch/arm64/kernel/vdso/Makefile | 4 +
arch/arm64/mm/context.c | 8 ++
arch/arm64/mm/init.c | 2 +-
arch/s390/hypfs/inode.c | 12 +--
drivers/acpi/bus.c | 56 +++++++++----
drivers/acpi/device_pm.c | 1 +
drivers/base/regmap/regmap.c | 5 +-
drivers/firmware/efi/efi.c | 6 +-
drivers/gpio/gpio-crystalcove.c | 1 +
drivers/iio/accel/kxcjk-1013.c | 1 +
drivers/infiniband/ulp/isert/ib_isert.c | 18 +++-
drivers/infiniband/ulp/srp/ib_srp.c | 83 +++++++++----------
drivers/infiniband/ulp/srp/ib_srp.h | 2 +-
drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
drivers/leds/led-class.c | 7 +-
drivers/misc/mei/client.c | 2 +-
drivers/misc/mei/hw-me.c | 59 ++++++++++++-
drivers/misc/mei/hw-txe.c | 33 +++++---
drivers/misc/mei/mei_dev.h | 11 +++
drivers/mtd/maps/dc21285.c | 4 +-
drivers/mtd/mtd_blkdevs.c | 5 ++
drivers/of/address.c | 2 +-
drivers/pci/Kconfig | 4 +
drivers/pci/bus.c | 10 +--
drivers/pci/hotplug/pciehp_hpc.c | 52 ++++++++----
drivers/pci/pci.c | 11 +++
drivers/pci/probe.c | 12 +--
drivers/pcmcia/topic.h | 16 ++++
drivers/regulator/core.c | 2 +-
drivers/regulator/max77686.c | 6 +-
drivers/scsi/ipr.h | 2 +-
drivers/scsi/scsi_transport_srp.c | 58 +++++++------
drivers/spi/spi-orion.c | 25 +++++-
drivers/spi/spi.c | 11 +--
drivers/video/fbdev/mxsfb.c | 68 +++++++++++----
fs/configfs/mount.c | 10 +--
fs/debugfs/inode.c | 11 +--
fs/fuse/inode.c | 9 +-
fs/kernfs/dir.c | 38 ++++++++-
fs/kernfs/inode.c | 2 +
fs/libfs.c | 96 ++++++++++++++++++++++
fs/namespace.c | 31 ++++++-
fs/proc/generic.c | 23 ++++++
fs/proc/inode.c | 4 +
fs/proc/internal.h | 6 ++
fs/proc/proc_sysctl.c | 37 +++++++++
fs/proc/root.c | 9 +-
fs/pstore/inode.c | 12 +--
fs/sysfs/dir.c | 34 ++++++++
fs/sysfs/mount.c | 5 +-
include/linux/acpi.h | 2 +
include/linux/fs.h | 4 +-
include/linux/kernfs.h | 3 +
include/linux/kmemleak.h | 6 +-
include/linux/pci.h | 18 ++--
include/linux/sysctl.h | 3 +
include/linux/sysfs.h | 15 ++++
include/linux/types.h | 12 ++-
init/main.c | 1 +
kernel/cgroup.c | 10 +--
kernel/irq/devres.c | 4 +-
kernel/livepatch/core.c | 18 ++--
kernel/rcu/tiny.c | 5 ++
kernel/sysctl.c | 8 +-
mm/kmemleak.c | 28 +++++--
mm/mempolicy.c | 38 +++++----
mm/percpu.c | 2 +-
security/inode.c | 10 +--
security/selinux/selinuxfs.c | 11 ++-
security/smack/smackfs.c | 8 +-
sound/core/pcm.c | 6 +-
sound/pci/hda/hda_intel.c | 4 +
sound/pci/hda/patch_realtek.c | 25 ++++++
tools/testing/selftests/Makefile | 2 +-
83 files changed, 1006 insertions(+), 329 deletions(-)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-19 19:10 Greg Kroah-Hartman
@ 2015-07-20 3:17 ` Guenter Roeck
2015-07-20 7:18 ` Sudip Mukherjee
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Guenter Roeck @ 2015-07-20 3:17 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel; +Cc: torvalds, akpm, shuah.kh, stable
On 07/19/2015 12:10 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.0.9 release.
> There are 58 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> Anything received after that time might be too late.
>
Build results:
total: 124 pass: 124 fail: 0
Qemu test results:
total: 30 pass: 30 fail: 0
Details are available at http://server.roeck-us.net:8010/builders/
Guenter
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-19 19:10 Greg Kroah-Hartman
2015-07-20 3:17 ` Guenter Roeck
@ 2015-07-20 7:18 ` Sudip Mukherjee
2015-07-20 17:18 ` Shuah Khan
2015-07-20 21:29 ` Rafael J. Wysocki
3 siblings, 0 replies; 13+ messages in thread
From: Sudip Mukherjee @ 2015-07-20 7:18 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, torvalds, akpm, linux, shuah.kh, stable
On Sun, Jul 19, 2015 at 12:10:38PM -0700, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.0.9 release.
> There are 58 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> Anything received after that time might be too late.
Compiled and booted on x86_32. No errors in dmesg.
regards
sudip
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-19 19:10 Greg Kroah-Hartman
2015-07-20 3:17 ` Guenter Roeck
2015-07-20 7:18 ` Sudip Mukherjee
@ 2015-07-20 17:18 ` Shuah Khan
2015-07-20 21:29 ` Rafael J. Wysocki
3 siblings, 0 replies; 13+ messages in thread
From: Shuah Khan @ 2015-07-20 17:18 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel; +Cc: torvalds, akpm, linux, shuah.kh, stable
On 07/19/2015 01:10 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.0.9 release.
> There are 58 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.0.9-rc1.gz
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-19 19:10 Greg Kroah-Hartman
` (2 preceding siblings ...)
2015-07-20 17:18 ` Shuah Khan
@ 2015-07-20 21:29 ` Rafael J. Wysocki
2015-07-20 22:04 ` Greg Kroah-Hartman
3 siblings, 1 reply; 13+ messages in thread
From: Rafael J. Wysocki @ 2015-07-20 21:29 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, torvalds, akpm, linux, shuah.kh, stable
On Sunday, July 19, 2015 12:10:38 PM Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.0.9 release.
> There are 58 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> Anything received after that time might be too late.
Can you please add commit 0294112ee313 (ACPI / PNP: Reserve ACPI resources
at the fs_initcall_sync stage) to this series too?
It fixes an exsiting regression in earlier 4.0.y.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-20 21:29 ` Rafael J. Wysocki
@ 2015-07-20 22:04 ` Greg Kroah-Hartman
2015-07-20 22:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 13+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-20 22:04 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-kernel, torvalds, akpm, linux, shuah.kh, stable
On Mon, Jul 20, 2015 at 11:29:28PM +0200, Rafael J. Wysocki wrote:
> On Sunday, July 19, 2015 12:10:38 PM Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.0.9 release.
> > There are 58 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> > Anything received after that time might be too late.
>
> Can you please add commit 0294112ee313 (ACPI / PNP: Reserve ACPI resources
> at the fs_initcall_sync stage) to this series too?
>
> It fixes an exsiting regression in earlier 4.0.y.
How about I wait for the next 4.0.y, which will be out later this week,
as it would be good for people to be able to test this patch out well.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-20 22:04 ` Greg Kroah-Hartman
@ 2015-07-20 22:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2015-07-20 22:38 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, torvalds, akpm, linux, shuah.kh, stable
On Monday, July 20, 2015 03:04:06 PM Greg Kroah-Hartman wrote:
> On Mon, Jul 20, 2015 at 11:29:28PM +0200, Rafael J. Wysocki wrote:
> > On Sunday, July 19, 2015 12:10:38 PM Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.0.9 release.
> > > There are 58 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Tue Jul 21 19:08:01 UTC 2015.
> > > Anything received after that time might be too late.
> >
> > Can you please add commit 0294112ee313 (ACPI / PNP: Reserve ACPI resources
> > at the fs_initcall_sync stage) to this series too?
> >
> > It fixes an exsiting regression in earlier 4.0.y.
>
> How about I wait for the next 4.0.y, which will be out later this week,
> as it would be good for people to be able to test this patch out well.
Yes, that should work too.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
@ 2015-07-21 17:13 Donald Parsons
2015-07-21 18:13 ` Greg Kroah-Hartman
0 siblings, 1 reply; 13+ messages in thread
From: Donald Parsons @ 2015-07-21 17:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman
Greg,
The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon
Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14)
This mis-compile was fixed in 4.1-rc8. The diff was:
diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
linux-4.1-rc8/arch/x86/kvm/mmu.c
--- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400
+++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400
@@ -4215,13 +4215,13 @@
u64 entry, gentry, *spte;
int npte;
bool remote_flush, local_flush, zap_page;
- union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
- .cr0_wp = 1,
- .cr4_pae = 1,
- .nxe = 1,
- .smep_andnot_wp = 1,
- .smap_andnot_wp = 1,
- };
+ union kvm_mmu_page_role mask = { };
+
+ mask.cr0_wp = 1;
+ mask.cr4_pae = 1;
+ mask.nxe = 1;
+ mask.smep_andnot_wp = 1;
+ mask.smap_andnot_wp = 1;
/*
* If we don't have indirect shadow pages, it means no page is
Please add to linux-4.0.9 so older compilers will work.
Thanks,
Don Parsons
PS: Compile error is :
CC [M] arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function kvm_mmu_pte_write:
arch/x86/kvm/mmu.c:4219:3: error: unknown field cr0_wp specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field cr4_pae specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4221:3: error: unknown field nxe specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4222:3: error: unknown field smep_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4223:3: error: unknown field smap_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
(anonymous))
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-21 17:13 [PATCH 4.0 00/58] 4.0.9-stable review Donald Parsons
@ 2015-07-21 18:13 ` Greg Kroah-Hartman
2015-07-21 21:02 ` Donald Parsons
0 siblings, 1 reply; 13+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-21 18:13 UTC (permalink / raw)
To: Donald Parsons; +Cc: linux-kernel
On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> Greg,
>
> The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon
> Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14)
>
> This mis-compile was fixed in 4.1-rc8. The diff was:
>
> diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> linux-4.1-rc8/arch/x86/kvm/mmu.c
> --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400
> +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400
> @@ -4215,13 +4215,13 @@
> u64 entry, gentry, *spte;
> int npte;
> bool remote_flush, local_flush, zap_page;
> - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> - .cr0_wp = 1,
> - .cr4_pae = 1,
> - .nxe = 1,
> - .smep_andnot_wp = 1,
> - .smap_andnot_wp = 1,
> - };
> + union kvm_mmu_page_role mask = { };
> +
> + mask.cr0_wp = 1;
> + mask.cr4_pae = 1;
> + mask.nxe = 1;
> + mask.smep_andnot_wp = 1;
> + mask.smap_andnot_wp = 1;
>
> /*
> * If we don't have indirect shadow pages, it means no page is
>
>
> Please add to linux-4.0.9 so older compilers will work.
What is the commit id in Linus's tree that resolves this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-21 18:13 ` Greg Kroah-Hartman
@ 2015-07-21 21:02 ` Donald Parsons
2015-07-21 21:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 13+ messages in thread
From: Donald Parsons @ 2015-07-21 21:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Andrew Morton
On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> > Greg,
> >
> > The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> > a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon
> > Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14)
> >
> > This mis-compile was fixed in 4.1-rc8. The diff was:
> >
> > diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> > linux-4.1-rc8/arch/x86/kvm/mmu.c
> > --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400
> > +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400
> > @@ -4215,13 +4215,13 @@
> > u64 entry, gentry, *spte;
> > int npte;
> > bool remote_flush, local_flush, zap_page;
> > - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> > - .cr0_wp = 1,
> > - .cr4_pae = 1,
> > - .nxe = 1,
> > - .smep_andnot_wp = 1,
> > - .smap_andnot_wp = 1,
> > - };
> > + union kvm_mmu_page_role mask = { };
> > +
> > + mask.cr0_wp = 1;
> > + mask.cr4_pae = 1;
> > + mask.nxe = 1;
> > + mask.smep_andnot_wp = 1;
> > + mask.smap_andnot_wp = 1;
> >
> > /*
> > * If we don't have indirect shadow pages, it means no page is
> >
> >
> > Please add to linux-4.0.9 so older compilers will work.
>
> What is the commit id in Linus's tree that resolves this?
I do not know but I found this in Linus' linux-4.1-rc8 email announce:
Andrew Morton (1):
arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
which must be it. Added Andrew to cc as he hopefully knows the answer
to your question.
Thanks,
Don Parsons
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-21 21:02 ` Donald Parsons
@ 2015-07-21 21:10 ` Greg Kroah-Hartman
2015-07-21 22:14 ` Donald Parsons
0 siblings, 1 reply; 13+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-21 21:10 UTC (permalink / raw)
To: Donald Parsons; +Cc: linux-kernel, Andrew Morton
On Tue, Jul 21, 2015 at 05:02:31PM -0400, Donald Parsons wrote:
> On Tue, 2015-07-21 at 11:13 -0700, Greg Kroah-Hartman wrote:
> > On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> > > Greg,
> > >
> > > The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> > > a kvm back-port from 4.1-rc5 went in. (This is on Linux 4.1.2 SMP Mon
> > > Jul 13 18:08:30 EDT 2015 x86_64 Fedora 14)
> > >
> > > This mis-compile was fixed in 4.1-rc8. The diff was:
> > >
> > > diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> > > linux-4.1-rc8/arch/x86/kvm/mmu.c
> > > --- linux-4.1-rc7/arch/x86/kvm/mmu.c 2015-07-15 00:05:34.000000000 -0400
> > > +++ linux-4.1-rc8/arch/x86/kvm/mmu.c 2015-07-15 00:07:45.000000000 -0400
> > > @@ -4215,13 +4215,13 @@
> > > u64 entry, gentry, *spte;
> > > int npte;
> > > bool remote_flush, local_flush, zap_page;
> > > - union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> > > - .cr0_wp = 1,
> > > - .cr4_pae = 1,
> > > - .nxe = 1,
> > > - .smep_andnot_wp = 1,
> > > - .smap_andnot_wp = 1,
> > > - };
> > > + union kvm_mmu_page_role mask = { };
> > > +
> > > + mask.cr0_wp = 1;
> > > + mask.cr4_pae = 1;
> > > + mask.nxe = 1;
> > > + mask.smep_andnot_wp = 1;
> > > + mask.smap_andnot_wp = 1;
> > >
> > > /*
> > > * If we don't have indirect shadow pages, it means no page is
> > >
> > >
> > > Please add to linux-4.0.9 so older compilers will work.
> >
> > What is the commit id in Linus's tree that resolves this?
>
> I do not know but I found this in Linus' linux-4.1-rc8 email announce:
>
> Andrew Morton (1):
> arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
>
> which must be it. Added Andrew to cc as he hopefully knows the answer
> to your question.
You can dig through git to find it pretty easily...
Anyway, given that the 4.0 release I'm doing at the moment is the last
one, and it's end-of-life, this is a bit late and isn't going to matter
much. People should be on 4.1 already.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-21 21:10 ` Greg Kroah-Hartman
@ 2015-07-21 22:14 ` Donald Parsons
2015-07-22 3:20 ` Greg Kroah-Hartman
0 siblings, 1 reply; 13+ messages in thread
From: Donald Parsons @ 2015-07-21 22:14 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Andrew Morton
On Tue, 2015-07-21 at 14:10 -0700, Greg Kroah-Hartman wrote:
> > Andrew Morton (1):
> > arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
> >
> > which must be it. Added Andrew to cc as he hopefully knows the
> answer to your question.
>
> You can dig through git to find it pretty easily...
>
> Anyway, given that the 4.0 release I'm doing at the moment is the last
> one, and it's end-of-life, this is a bit late and isn't going to
> matter much. People should be on 4.1 already.
Okay. But just in case. I had to learn about git and do a checkout.
git log v4.1-rc8 arch/x86/kvm/mmu.c shows:
commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
Author: Andrew Morton <akpm@linux-foundation.org>
Date: Wed Jun 10 11:15:02 2015 -0700
arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
Fix this compile issue with gcc-4.4.4:
arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified
in initializer
arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified
in initializer
arch/x86/kvm/mmu.c:4257: warning: excess elements in union
initializer
...
gcc-4.4.4 (at least) has issues when using anonymous unions in
initializers.
Fixes: edc90b7dc4ceef6 ("KVM: MMU: fix SMAP virtualization")
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Hopefully commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
is what you were looking for. If not, very sorry for interrupting you.
Thanks,
Don
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4.0 00/58] 4.0.9-stable review
2015-07-21 22:14 ` Donald Parsons
@ 2015-07-22 3:20 ` Greg Kroah-Hartman
0 siblings, 0 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-22 3:20 UTC (permalink / raw)
To: Donald Parsons; +Cc: linux-kernel, Andrew Morton
On Tue, Jul 21, 2015 at 06:14:06PM -0400, Donald Parsons wrote:
> On Tue, 2015-07-21 at 14:10 -0700, Greg Kroah-Hartman wrote:
> > > Andrew Morton (1):
> > > arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
> > >
> > > which must be it. Added Andrew to cc as he hopefully knows the
> > answer to your question.
> >
> > You can dig through git to find it pretty easily...
> >
> > Anyway, given that the 4.0 release I'm doing at the moment is the last
> > one, and it's end-of-life, this is a bit late and isn't going to
> > matter much. People should be on 4.1 already.
>
> Okay. But just in case. I had to learn about git and do a checkout.
>
> git log v4.1-rc8 arch/x86/kvm/mmu.c shows:
>
> commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
> Author: Andrew Morton <akpm@linux-foundation.org>
> Date: Wed Jun 10 11:15:02 2015 -0700
>
> arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
>
> Fix this compile issue with gcc-4.4.4:
>
> arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
> arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified
> in initializer
> arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified
> in initializer
> arch/x86/kvm/mmu.c:4257: warning: excess elements in union
> initializer
> ...
>
> gcc-4.4.4 (at least) has issues when using anonymous unions in
> initializers.
>
> Fixes: edc90b7dc4ceef6 ("KVM: MMU: fix SMAP virtualization")
> Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Davidlohr Bueso <dave@stgolabs.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
>
> Hopefully commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
> is what you were looking for. If not, very sorry for interrupting you.
Thanks, that's exactly what I needed. I've queued it up, in the
off-chance that there would be another 4.0-stable kernel, but I don't
think there will be. Please move to 4.1 at this point in time.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-07-22 3:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21 17:13 [PATCH 4.0 00/58] 4.0.9-stable review Donald Parsons
2015-07-21 18:13 ` Greg Kroah-Hartman
2015-07-21 21:02 ` Donald Parsons
2015-07-21 21:10 ` Greg Kroah-Hartman
2015-07-21 22:14 ` Donald Parsons
2015-07-22 3:20 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-07-19 19:10 Greg Kroah-Hartman
2015-07-20 3:17 ` Guenter Roeck
2015-07-20 7:18 ` Sudip Mukherjee
2015-07-20 17:18 ` Shuah Khan
2015-07-20 21:29 ` Rafael J. Wysocki
2015-07-20 22:04 ` Greg Kroah-Hartman
2015-07-20 22:38 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.