Re: [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Tue, Jul 21, 2015 at 10:18:06AM -0700, Joe Perches wrote:
> On Mon, 2015-07-20 at 21:15 -0400, Steven Rostedt wrote:
> > On Mon, 20 Jul 2015 18:06:19 -0700 Joe Perches <joe@perches.com> wrote:
> > > On Mon, 2015-07-20 at 20:55 -0400, Steven Rostedt wrote:
> > > > On Fri, 17 Jul 2015 15:37:54 -0700
> > > > Joe Perches <joe@perches.com> wrote:
> > > > > > +		if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) {
> > > > > It'd be faster perl without capture groups:
> > > > Is checkpatch such a critical code path that we could possibly notice
> > > > the difference in speed? Although the above may be few microseconds
> > > > slower, to me, the above looks a hell of a lot more readable.
> 
> Not to me. Compact is generally more readable.
> 
> > > Regardless, it's not as capable as it wouldn't find
> > > any miswritten form like
> > > 
> > > 	synchronize_<foo>_expedited ( args... )
> > 
> > Then that's a better rational than performance.
> 
> Part and parcel.
> 
> Regardless, I'll send a patch once it's actually pushed.

Current plan is to push it into the upcoming merge window.

							Thanx, Paul