From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934128AbbGUXsL (ORCPT ); Tue, 21 Jul 2015 19:48:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42611 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933284AbbGUXsK (ORCPT ); Tue, 21 Jul 2015 19:48:10 -0400 Date: Tue, 21 Jul 2015 16:48:07 -0700 From: Stephen Boyd To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Peter De Schrijver , Tero Kristo , Russell King , Dinh Nguyen Subject: Re: [PATCH v5 1/8] clk: divider: switch to GENMASK() Message-ID: <20150721234807.GA15042@codeaurora.org> References: <1436796468-45723-1-git-send-email-andriy.shevchenko@linux.intel.com> <1436796468-45723-2-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436796468-45723-2-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13, Andy Shevchenko wrote: > Convert the code to use GENMASK() helper instead of div_mask() macro. > > Signed-off-by: Andy Shevchenko > --- > drivers/clk/clk-divider.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c > index 706b578..3bde790 100644 > --- a/drivers/clk/clk-divider.c > +++ b/drivers/clk/clk-divider.c > @@ -30,8 +30,6 @@ > #include ? > @@ -391,10 +389,10 @@ static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate, > spin_lock_irqsave(divider->lock, flags); > > if (divider->flags & CLK_DIVIDER_HIWORD_MASK) { > - val = div_mask(divider->width) << (divider->shift + 16); > + val = GENMASK(divider->width - 1, 0) << (divider->shift + 16); > } else { > val = clk_readl(divider->reg); > - val &= ~(div_mask(divider->width) << divider->shift); > + val &= ~(GENMASK(divider->width - 1, 0) << divider->shift); Shouldn't this be doing the shift in the GENMASK? start = divider->width - 1 + divider->shift; end = divider->shift; ... val &= ~GENMASK(start, end); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project