From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/3] fsnotify: Fix oops in fsnotify_clear_marks_by_group_flags() Date: Tue, 21 Jul 2015 17:26:38 -0700 Message-ID: <20150722002638.GA32550@kroah.com> References: <1436966481-12517-1-git-send-email-jack@suse.com> <1436966481-12517-2-git-send-email-jack@suse.com> <55AB7A3D.4000008@gmail.com> <20150720144642.GE3131@quack.suse.cz> <20150721200339.GA12971@quack.suse.cz> <20150721203522.GA10985@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Andrew Morton , Jan Kara , Kinglong Mee , linux-fsdevel , stable To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jul 21, 2015 at 04:14:00PM -0700, Linus Torvalds wrote: > On Tue, Jul 21, 2015 at 1:35 PM, Jan Kara wrote: > > > > Linus, please revert commit > > > > a2673b6e0406 fsnotify: fix oops in fsnotify_clear_marks_by_group_flags() > > > > It fixes the oops but introduces a race which can leak event structure on > > group destruction. I'll fix the oops in a different way and it would > > basically undo what this patch did anyway. Thanks! > > Ok, it is reverted in my tree now (and doing a build before pushing it > out). However, that original commit was also marked for stable, so we > need to kill it there. > > Greg, is there some protocol to kill stable entries? I did *not* mark > the revert for stable, because I'm hoping the original never made it > into the queue anyway (it was committed last Friday), but I don't know > of any way to notify stable except this kind of "hey guys, do not > apply that particular patch". That's the whole protocol, I'll go drop it from my queue now, it never made it into a stable release just yet. thanks, greg k-h