All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ARM: shmobile: r8a7779 Marzen legacy fix V2
Date: Wed, 22 Jul 2015 00:34:38 +0000	[thread overview]
Message-ID: <20150722003437.GA25644@verge.net.au> (raw)
In-Reply-To: <20150714072522.2854.69938.sendpatchset@little-apple>

On Tue, Jul 14, 2015 at 04:25:22PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Unbreak the r8a7779 Marzen legacy code provided by marzen_defconfig.
> 
> As it is today Marzen multiplatform is working, but the legacy code
> is broken. This patch intends to leave multiplatform as-is but do
> a simple one-shot fix to unbreak the legacy code base.
> 
> Without this patch there is no preset delay and the TWD is defined
> both in C code and in DT. Solve the delay by invoking shmobile_init_delay()
> and simply disable TWD in case of building for legacy.
> 
> Marzen legacy code will be removed in the near future, but until then
> we may as well avoid breaking it.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

I currently have this patch queued up.
However, as "[PATCH 00/03] ARM: shmobile: r8a7779 Marzen legacy removal" is
also queued up I have it in mind to drop this patch. The reasoning is
twofold:

* There seems little benefit to fix legacy code that is being removed
* There is a tedious merge conflict between fixing and removing the code

  parent reply	other threads:[~2015-07-22  0:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  7:25 [PATCH v2] ARM: shmobile: r8a7779 Marzen legacy fix V2 Magnus Damm
2015-07-15  0:23 ` Simon Horman
2015-07-15  5:59 ` Magnus Damm
2015-07-15  6:47 ` Simon Horman
2015-07-15  6:49 ` Magnus Damm
2015-07-15  6:53 ` Simon Horman
2015-07-15  6:55 ` Magnus Damm
2015-07-15  7:37 ` Geert Uytterhoeven
2015-07-16  0:59 ` Simon Horman
2015-07-16  6:30 ` Geert Uytterhoeven
2015-07-22  0:34 ` Simon Horman [this message]
2015-07-24  8:39 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150722003437.GA25644@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.