Re: [PATCH v4 3/6] clk: fractional-divider: keep mwidth and nwidth internally

[Stephen Boyd <sboyd@codeaurora.org>]

On 07/14, Andy Shevchenko wrote:
> diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c
> index 7cfcc56..16f42ae 100644
> --- a/drivers/clk/clk-fractional-divider.c
> +++ b/drivers/clk/clk-fractional-divider.c
> @@ -128,9 +128,11 @@ struct clk *clk_register_fractional_divider(struct device *dev,
>  
>  	fd->reg = reg;
>  	fd->mshift = mshift;
> -	fd->mmask = (BIT(mwidth) - 1) << mshift;
> +	fd->mwidth = mwidth;
> +	fd->mmask = GENMASK(mwidth - 1, 0) << mshift;
>  	fd->nshift = nshift;
> -	fd->nmask = (BIT(nwidth) - 1) << nshift;
> +	fd->nwidth = nwidth;
> +	fd->nmask = GENMASK(nwidth - 1, 0) << nshift;

Please do the shifts in the GENMASK.
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project