Re: [PATCH 4.0 00/58] 4.0.9-stable review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Jul 21, 2015 at 06:14:06PM -0400, Donald Parsons wrote:
> On Tue, 2015-07-21 at 14:10 -0700, Greg Kroah-Hartman wrote:
> > > Andrew Morton (1):
> > >       arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
> > > 
> > > which must be it.  Added Andrew to cc as he hopefully knows the
> > answer to your question.
> > 
> > You can dig through git to find it pretty easily...
> > 
> > Anyway, given that the 4.0 release I'm doing at the moment is the last
> > one, and it's end-of-life, this is a bit late and isn't going to
> > matter much.  People should be on 4.1 already.
> 
> Okay. But just in case.  I had to learn about git and do a checkout.
> 
> git log v4.1-rc8 arch/x86/kvm/mmu.c  shows:
> 
> commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
> Author: Andrew Morton <akpm@linux-foundation.org>
> Date:   Wed Jun 10 11:15:02 2015 -0700
> 
>     arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug
>     
>     Fix this compile issue with gcc-4.4.4:
>     
>        arch/x86/kvm/mmu.c: In function 'kvm_mmu_pte_write':
>        arch/x86/kvm/mmu.c:4256: error: unknown field 'cr0_wp' specified
> in initializer
>        arch/x86/kvm/mmu.c:4257: error: unknown field 'cr4_pae' specified
> in initializer
>        arch/x86/kvm/mmu.c:4257: warning: excess elements in union
> initializer
>        ...
>     
>     gcc-4.4.4 (at least) has issues when using anonymous unions in
>     initializers.
>     
>     Fixes: edc90b7dc4ceef6 ("KVM: MMU: fix SMAP virtualization")
>     Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>     Cc: Paolo Bonzini <pbonzini@redhat.com>
>     Cc: Davidlohr Bueso <dave@stgolabs.net>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> 
> Hopefully commit 5ec45a192fe6e287f0fc06d5ca4f3bd446d94803
> is what you were looking for.  If not, very sorry for interrupting you.

Thanks, that's exactly what I needed.  I've queued it up, in the
off-chance that there would be another 4.0-stable kernel, but I don't
think there will be.  Please move to 4.1 at this point in time.

thanks,

greg k-h