From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: ahmed.taahir@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] Support python 3 in utils/key2pub.py.
Date: Wed, 22 Jul 2015 04:50:45 +0200 [thread overview]
Message-ID: <20150722045045.30642c25@mir> (raw)
In-Reply-To: <1437525466-27512-2-git-send-email-ahmed.taahir@gmail.com>
Hi
On 2015-07-21, ahmed.taahir@gmail.com wrote:
> From: Taahir Ahmed <ahmed.taahir@gmail.com>
>
> utils/key2pub.py can now be run under either python 2.7 or python 3.x.
> This required some minor syntactical changes as well as switching from
> M2Crypto to pycrypto, since M2Crypto doesn't support python 3.x.
[...]
> diff --git a/Makefile b/Makefile
> index a3ead30..65fc780 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -112,7 +112,7 @@ $(REG_BIN):
> keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
> $(NQ) ' GEN ' $@
> $(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
> - $(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
> + $(Q) python /utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
[...]
Without having tested it, nor being that familiar with python coding,
but this hunk seems to be problematic on two accords.
You omit $(pwd) from ./utils/key2pub.py, while /utils/key2pub.py
won't exist.
As little as I know about python packaging policies in Debian
(and probably Fedora), /usr/bin/python is never supposed to point
to python3 - afaik the interpreter should always be called python3
there, so I don't really see how that's going to work there.
Sorry if I missed anything obvious, but these things just caught
my attention without having looked any deeper.
Regards
Stefan Lippers-Hollmann
next prev parent reply other threads:[~2015-07-22 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 0:37 Support Python3 in the crda buildsystem ahmed.taahir
2015-07-22 0:37 ` [PATCH 1/2] Support python 3 in utils/key2pub.py ahmed.taahir
2015-07-22 2:50 ` Stefan Lippers-Hollmann [this message]
2015-07-22 2:59 ` Taahir Ahmed
2015-07-22 4:01 ` Stefan Lippers-Hollmann
2015-07-22 0:37 ` [PATCH 2/2] Small build system improvements ahmed.taahir
-- strict thread matches above, loose matches on Subject: below --
2015-07-22 5:21 Support Python 3 in the crda build system (Take 2) ahmed.taahir
2015-07-22 5:21 ` [PATCH 1/2] Support python 3 in utils/key2pub.py ahmed.taahir
2019-12-25 16:19 ` jtojnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722045045.30642c25@mir \
--to=s.l-h@gmx.de \
--cc=ahmed.taahir@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.