From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC] libxl: fix build with glibc < 2.9 Date: Wed, 22 Jul 2015 13:24:48 +0100 Message-ID: <20150722122448.GD6831@zion.uk.xensource.com> References: <55AD223C02000078000932DC@mail.emea.novell.com> <1437487589.8383.34.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHt4v-0007Ek-6X for xen-devel@lists.xenproject.org; Wed, 22 Jul 2015 12:24:53 +0000 Content-Disposition: inline In-Reply-To: <1437487589.8383.34.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , Stefano Stabellini , Andrew Cooper , Ian Jackson , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On Tue, Jul 21, 2015 at 03:06:29PM +0100, Ian Campbell wrote: > On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote: > > htobe*() and be*toh() don't exist there. While replacing the 32-bit > > ones with hton() and ntoh() would be possible, there wouldn't be an > > obvious replacement for the 64-bit ones. Hence just take what current > > glibc (2.21) has (assuming __bswap_*() exists, which it does back to > > at least 2.4 according to my checking). > > > > Signed-off-by: Jan Beulich > > --- > > Not sure whether I picked an appropriate header to place this in, or > > an appropriate #ifdef to hook this onto. Hence the RFC. > > I think they will do. > > I was a bit confused by xl.c including libxl_osdeps.h, but I think that > is an aberration and we don't install the header so it is not really > "public". > > Acked-by: Ian Campbell I was about to object putting them in libxl_osdep.h because they are not really OS-dependent. However we've dumped something similar there before so I withdraw my objection. FWIW Acked-by: Wei Liu