From: "Richard W.M. Jones" <rjones@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno.
Date: Wed, 22 Jul 2015 14:22:18 +0100 [thread overview]
Message-ID: <20150722132218.GB22921@redhat.com> (raw)
In-Reply-To: <20150722131749.GC21772@localhost.localdomain>
On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote:
> Both nbd and sheepdog handle it in a similar fashion (i.e. not relying
> on errno being set on inet_connect failure). However, both nbd and
> sheepdog use -EIO as the error return, and I think that makes more
> sense. What do you think?
If you prefer -- I don't mind as long as it doesn't segfault :-)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2015-07-22 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 13:07 [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno Richard W.M. Jones
2015-07-22 13:07 ` Richard W.M. Jones
2015-07-22 13:10 ` Daniel P. Berrange
2015-07-22 13:17 ` Richard W.M. Jones
2015-07-22 13:24 ` Kevin Wolf
2015-07-22 13:17 ` Jeff Cody
2015-07-22 13:22 ` Richard W.M. Jones [this message]
2015-07-22 13:26 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722132218.GB22921@redhat.com \
--to=rjones@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.