From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 23 Jul 2015 17:01:19 +0200 From: Alexandre Belloni To: Octavian Purdila Cc: Linus Walleij , Mika Westerberg , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Alessandro Zummo , Srinivas Pandruvada , linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] rtc: fix drivers that consider 0 as a valid IRQ in client->irq Message-ID: <20150723150119.GA14893@piout.net> References: <1433512783-8183-1-git-send-email-octavian.purdila@intel.com> <1433512783-8183-3-git-send-email-octavian.purdila@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1433512783-8183-3-git-send-email-octavian.purdila@intel.com> List-ID: On 05/06/2015 at 16:59:43 +0300, Octavian Purdila wrote : > Since patch "i2c / ACPI: Use 0 to indicate that device does not have > interrupt assigned" [1], 0 is not a valid i2c client irq anymore, so > change all driver's checks accordingly. > > The same issue occurs when the device is instantiated via device tree > with no IRQ, or from the i2c sysfs interface, even before the patch > above. > > [1] http://lkml.kernel.org/g/<1430908148-201129-3-git-send-email-mika.westerberg@linux.intel.com> > > Signed-off-by: Octavian Purdila > Reviewed-by: Mika Westerberg > Acked-by: Alexandre Belloni Applied, thanks. I included the final commit id instead of the link to the mailing list redirector. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id ec7si283382wib.3.2015.07.23.08.01.21 for ; Thu, 23 Jul 2015 08:01:21 -0700 (PDT) Date: Thu, 23 Jul 2015 17:01:19 +0200 From: Alexandre Belloni To: Octavian Purdila Cc: Linus Walleij , Mika Westerberg , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Alessandro Zummo , Srinivas Pandruvada , linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v3 2/2] rtc: fix drivers that consider 0 as a valid IRQ in client->irq Message-ID: <20150723150119.GA14893@piout.net> References: <1433512783-8183-1-git-send-email-octavian.purdila@intel.com> <1433512783-8183-3-git-send-email-octavian.purdila@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1433512783-8183-3-git-send-email-octavian.purdila@intel.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 05/06/2015 at 16:59:43 +0300, Octavian Purdila wrote : > Since patch "i2c / ACPI: Use 0 to indicate that device does not have > interrupt assigned" [1], 0 is not a valid i2c client irq anymore, so > change all driver's checks accordingly. > > The same issue occurs when the device is instantiated via device tree > with no IRQ, or from the i2c sysfs interface, even before the patch > above. > > [1] http://lkml.kernel.org/g/<1430908148-201129-3-git-send-email-mika.westerberg@linux.intel.com> > > Signed-off-by: Octavian Purdila > Reviewed-by: Mika Westerberg > Acked-by: Alexandre Belloni Applied, thanks. I included the final commit id instead of the link to the mailing list redirector. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.