Re: [RFT PATCH] ARM: pci: kill pcibios_msi_controller

[Bjorn Helgaas <bhelgaas@google.com>]

On Wed, Jul 22, 2015 at 01:49:29PM +0100, Lorenzo Pieralisi wrote:

> > >> @@ -483,14 +471,25 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw,
> > >>  				break;
> > >>  			}
> > >>  
> > >> -			if (hw->scan)
> > >> +			if (hw->scan) {
> > >>  				sys->bus = hw->scan(nr, sys);
> > >> -			else
> > >> -				sys->bus = pci_scan_root_bus(parent, sys->busnr,
> > >> -						hw->ops, sys, &sys->resources);
> > >> +				if (!sys->bus)
> > >> +					panic("PCI: unable to scan bus!");
> > 
> > This was in the original code, but I have to ask: Do we really want to
> > panic the kernel if we couldn't scan the bus? Worse case, the system
> > won't be able to boot at all and will panic somewhere else anyway, but
> > we should give the user a chance to understand what's happening...
> 
> No, it was in the original code but I was very tempted to remove it
> or merge the error paths and make it a warning, and that's what I am
> going to do, unless someone complains (that panic statement has been there
> forever).

I agree the panic should be removed.  I would do it in a separate patch
since it's not related to your main objective here.

Bjorn