From: Lee Jones <lee.jones@linaro.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: patches@opensource.wolfsonmicro.com, sameo@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mfd: arizona: Specify regmap endianness
Date: Thu, 23 Jul 2015 16:18:30 +0100 [thread overview]
Message-ID: <20150723151830.GL3436@x1> (raw)
In-Reply-To: <1437407627-9894-1-git-send-email-rf@opensource.wolfsonmicro.com>
On Mon, 20 Jul 2015, Richard Fitzgerald wrote:
> Explicitly set the regmap endianness instead of relying on
> the default being correct.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm5102-tables.c | 4 ++++
> drivers/mfd/wm5110-tables.c | 4 ++++
> drivers/mfd/wm8997-tables.c | 2 ++
> drivers/mfd/wm8998-tables.c | 2 ++
> 4 files changed, 12 insertions(+), 0 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index aeae6ec..3981123 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -1969,6 +1969,8 @@ const struct regmap_config wm5102_spi_regmap = {
> .reg_bits = 32,
> .pad_bits = 16,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM5102_MAX_REGISTER,
> .readable_reg = wm5102_readable_register,
> @@ -1983,6 +1985,8 @@ EXPORT_SYMBOL_GPL(wm5102_spi_regmap);
> const struct regmap_config wm5102_i2c_regmap = {
> .reg_bits = 32,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM5102_MAX_REGISTER,
> .readable_reg = wm5102_readable_register,
> diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
> index 12cad94..e92b1c8 100644
> --- a/drivers/mfd/wm5110-tables.c
> +++ b/drivers/mfd/wm5110-tables.c
> @@ -3007,6 +3007,8 @@ const struct regmap_config wm5110_spi_regmap = {
> .reg_bits = 32,
> .pad_bits = 16,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM5110_MAX_REGISTER,
> .readable_reg = wm5110_readable_register,
> @@ -3021,6 +3023,8 @@ EXPORT_SYMBOL_GPL(wm5110_spi_regmap);
> const struct regmap_config wm5110_i2c_regmap = {
> .reg_bits = 32,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM5110_MAX_REGISTER,
> .readable_reg = wm5110_readable_register,
> diff --git a/drivers/mfd/wm8997-tables.c b/drivers/mfd/wm8997-tables.c
> index c0c25d75..01bb57b 100644
> --- a/drivers/mfd/wm8997-tables.c
> +++ b/drivers/mfd/wm8997-tables.c
> @@ -1521,6 +1521,8 @@ static bool wm8997_volatile_register(struct device *dev, unsigned int reg)
> const struct regmap_config wm8997_i2c_regmap = {
> .reg_bits = 32,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM8997_MAX_REGISTER,
> .readable_reg = wm8997_readable_register,
> diff --git a/drivers/mfd/wm8998-tables.c b/drivers/mfd/wm8998-tables.c
> index 60e8622..e6de3cd 100644
> --- a/drivers/mfd/wm8998-tables.c
> +++ b/drivers/mfd/wm8998-tables.c
> @@ -1580,6 +1580,8 @@ static bool wm8998_volatile_register(struct device *dev, unsigned int reg)
> const struct regmap_config wm8998_i2c_regmap = {
> .reg_bits = 32,
> .val_bits = 16,
> + .reg_format_endian = REGMAP_ENDIAN_BIG,
> + .val_format_endian = REGMAP_ENDIAN_BIG,
>
> .max_register = WM8998_MAX_REGISTER,
> .readable_reg = wm8998_readable_register,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2015-07-23 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 15:53 [PATCH RESEND] mfd: arizona: Specify regmap endianness Richard Fitzgerald
2015-07-23 15:18 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723151830.GL3436@x1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.