From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg/aarch64: use 32-bit offset for 32-bit softmmu emulation
Date: Fri, 24 Jul 2015 00:21:11 +0200 [thread overview]
Message-ID: <20150723222111.GA20361@aurel32.net> (raw)
In-Reply-To: <1437689640-31364-1-git-send-email-rth@twiddle.net>
On 2015-07-23 15:14, Richard Henderson wrote:
> Similar to the same fix for user-mode, except this instance
> ocurrs on the softmmu path. Again, the softmmu addend must
> be the base register, while the guest address is the index.
>
> Cc: Claudio Fontana <claudio.fontana@huawei.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>
> While applying Paolo's fix for user-mode, I noticed this.
> I've never seen this fail, but obviously what we have is wrong.
>
> This patch depends on Paolo's cleanup.
>
>
> r~
> ---
> tcg/aarch64/tcg-target.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Good catch!
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2015-07-23 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 22:14 [Qemu-devel] [PATCH] tcg/aarch64: use 32-bit offset for 32-bit softmmu emulation Richard Henderson
2015-07-23 22:21 ` Aurelien Jarno [this message]
2015-07-23 22:27 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723222111.GA20361@aurel32.net \
--to=aurelien@aurel32.net \
--cc=claudio.fontana@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.