From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart van Assche <bart.vanassche@sandisk.com>
Subject: Re: [PATCH 08/20] scsi_dh_alua: Make stpg synchronous
Date: Fri, 24 Jul 2015 16:51:03 +0200 [thread overview]
Message-ID: <20150724145103.GC29096@lst.de> (raw)
In-Reply-To: <1436346378-96518-9-git-send-email-hare@suse.de>
> - memset(h->buff, 0, stpg_len);
> - h->buff[4] = TPGS_STATE_OPTIMIZED & 0x0f;
> - h->buff[6] = (h->group_id >> 8) & 0xff;
> - h->buff[7] = h->group_id & 0xff;
> + memset(stpg_data, 0, stpg_len);
> + stpg_data[4] = TPGS_STATE_OPTIMIZED & 0x0f;
> + put_unaligned_be16(group_id, &stpg_data[6]);
Unrelated get/put_unaligned changes again.
> - if (!scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE,
> + if (!(driver_byte(retval) & DRIVER_SENSE) ||
> + !scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE,
Where does this come from?
> + (!h->pref) &&
no need for braces here.
next prev parent reply other threads:[~2015-07-24 14:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:05 [PATCHv2 00/20] asynchronous ALUA device handler Hannes Reinecke
2015-07-08 9:05 ` [PATCH 01/20] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-07-08 9:06 ` [PATCH 02/20] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-07-08 9:06 ` [PATCH 03/20] scsi_dh_alua: improved logging Hannes Reinecke
2015-07-08 9:06 ` [PATCH 04/20] scsi_dh_alua: Improve error handling Hannes Reinecke
2015-07-24 14:48 ` Christoph Hellwig
2015-07-25 15:42 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 05/20] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-07-08 9:06 ` [PATCH 06/20] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-07-08 9:06 ` [PATCH 07/20] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-07-24 14:48 ` Christoph Hellwig
2015-07-08 9:06 ` [PATCH 08/20] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-07-24 14:51 ` Christoph Hellwig [this message]
2015-07-25 15:44 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 09/20] scsi_dh_alua: switch to scsi_execute() Hannes Reinecke
2015-07-24 14:53 ` Christoph Hellwig
2015-07-25 15:44 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 10/20] scsi_dh_alua: put sense buffer on stack Hannes Reinecke
2015-07-08 9:06 ` [PATCH 11/20] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-07-24 14:58 ` Christoph Hellwig
2015-07-25 15:52 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 12/20] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-07-24 14:59 ` Christoph Hellwig
2015-07-08 9:06 ` [PATCH 13/20] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-07-24 15:00 ` Christoph Hellwig
2015-07-08 9:06 ` [PATCH 14/20] scsi_dh_alua: parse target device id Hannes Reinecke
2015-07-24 15:07 ` Christoph Hellwig
2015-07-24 15:28 ` Martin K. Petersen
2015-07-25 16:00 ` Hannes Reinecke
2015-07-25 15:53 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 15/20] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning" Hannes Reinecke
2015-07-08 9:06 ` [PATCH 16/20] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-07-24 15:21 ` Christoph Hellwig
2015-07-25 15:58 ` Hannes Reinecke
2015-07-08 9:06 ` [PATCH 17/20] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-07-08 9:06 ` [PATCH 18/20] scsi_dh_alua: update all port states Hannes Reinecke
2015-07-08 9:06 ` [PATCH 19/20] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-07-08 9:06 ` [PATCH 20/20] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724145103.GC29096@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.