All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zxing_cpp: New package
Date: Sun, 26 Jul 2015 14:11:55 +0200	[thread overview]
Message-ID: <20150726121155.GC3770@free.fr> (raw)
In-Reply-To: <CAGduivzTUvGvGs98N1eVnif0tb2ncoJSKD+cn4Y0DmcpET4waw@mail.gmail.com>

Maxime, All,

On 2015-07-26 13:27 +0200, Maxime Hadjinlian spake thusly:
> On Sun, Jul 26, 2015 at 12:21 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2015-07-24 00:08 +0200, Maxime Hadjinlian spake thusly:
[--SNIP--]
> >> +define ZXING_CPP_INSTALL_STAGING_CMDS
> >> +     for i in $$(find $(@D)/buildroot-build/core/src -iname *.h); do \
> >> +             $(INSTALL) -m 644 $$i $(TARGET_DIR)/usr/local/include; \
> >> +     done
> >> +endef
> >> +
> >> +define ZXING_CPP_INSTALL_TARGET_CMDS
> >> +     for i in $$(find $(@D)/buildroot-build/ -iname *.so -o -iname *.a); do \
> >> +             $(INSTALL) -m 644 $$i $(TARGET_DIR)/usr/lib; \
> >> +     done
> >> +     $(INSTALL) -m 755 $(@D)/buildroot-build/zxing $(TARGET_DIR)/usr/sbin
> >> +endef
> >
> > Why can't we use the standard 'install' rule for either staging or
> > target?
> There's no install in the CMakeLists from the original package,
> there's already multiple issues in their Github to add it but it
> doesn't seem like the maintainer is resolved to add them. Since I
> don't want to add a patch that'll just rot there, I went this way.

That's not how I interpret the comments in the issue report; on the
contrary, I understand that the maintainer will welcome pull requests
for new features, so if you were to send such a PR, it seems it would
have quite some good chances to get in.

Anyway, OK for the way you'r edoing it for now...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-07-26 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 22:08 [Buildroot] [PATCH] zxing_cpp: New package Maxime Hadjinlian
2015-07-25 22:21 ` Yann E. MORIN
2015-07-26 11:27   ` Maxime Hadjinlian
2015-07-26 12:11     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150726121155.GC3770@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.